Use fingerprint to detect changes in methods that are intrinsified.

Use fingerprint to detect changes in methods that are intrinsified.
Make sure that the fingerprints are portable across 32 and 64 bit platforms.
Committed: https://code.google.com/p/dart/source/detail?r=15217

[srdjan, 2012-11-21 01:45:55]

In a following CL will add also checks for inlined library methods.

[Florian Schneider, 2012-11-21 11:09:49]

dbc: While this is a good idea to keep the optimizer always in sync, I think we
should at the same time try to limit intrinsified/manually inlined methods to
native methods only. They probably change less often.

Dart-implemented library functions should be handled automatically by flow-graph
inlining.

[siva, 2012-11-21 17:33:14]

lgtm

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.cc
File runtime/vm/intrinsifier.cc (right):

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.cc...
runtime/vm/intrinsifier.cc:107: }
Since this function is used only under ASSERT you should
probably enclose it in
#if defined(DEBUG)
.....
....
#endif
(some linux builds may cause a warning)

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.h
File runtime/vm/intrinsifier.h (right):

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.h#...
runtime/vm/intrinsifier.h:13: // List of intrinsics: (class-name, function-name,
intrinsification method).
Could you add a comment here which states how one should
go about updating the value when they add a new function or
make modifications to an intrinsified method.

e.g: When adding a new function for intrinsification
add a 0 for the value and do the build, we should see a
fingerprint mismatch error. Take the expected value and
plug it in here..... or something like that.

[srdjan, 2012-11-21 18:10:09]

On 2012/11/21 11:09:49, Florian Schneider wrote:
> dbc: While this is a good idea to keep the optimizer always in sync, I think
we
> should at the same time try to limit intrinsified/manually inlined methods to
> native methods only. They probably change less often.
> 
> Dart-implemented library functions should be handled automatically by
flow-graph
> inlining.

Yes, we need to go over the intrinsics and check which one are needed. Note that
inlining is not always triggered, depending on caller's situation.

[srdjan, 2012-11-21 18:11:14]

Will also change hashcode of String and SourceFingerprint to use unsigned
integers and limit to 31 bits, thus making the fingerprint always positive.

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.cc
File runtime/vm/intrinsifier.cc (right):

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.cc...
runtime/vm/intrinsifier.cc:107: }
On 2012/11/21 17:33:14, siva wrote:
> Since this function is used only under ASSERT you should
> probably enclose it in
> #if defined(DEBUG)
> .....
> ....
> #endif
> (some linux builds may cause a warning)

Done.

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.h
File runtime/vm/intrinsifier.h (right):

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.h#...
runtime/vm/intrinsifier.h:13: // List of intrinsics: (class-name, function-name,
intrinsification method).
On 2012/11/21 17:33:14, siva wrote:
> Could you add a comment here which states how one should
> go about updating the value when they add a new function or
> make modifications to an intrinsified method.
> 
> e.g: When adding a new function for intrinsification
> add a 0 for the value and do the build, we should see a
> fingerprint mismatch error. Take the expected value and
> plug it in here..... or something like that.

Done.

[srdjan, 2012-11-21 18:55:38]

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.cc
File runtime/vm/intrinsifier.cc (right):

https://codereview.chromium.org/11421024/diff/9001/runtime/vm/intrinsifier.cc...
runtime/vm/intrinsifier.cc:107: }
On 2012/11/21 18:11:14, srdjan wrote:
> On 2012/11/21 17:33:14, siva wrote:
> > Since this function is used only under ASSERT you should
> > probably enclose it in
> > #if defined(DEBUG)
> > .....
> > ....
> > #endif
> > (some linux builds may cause a warning)
> 
> Done.

Backed out, since all functions used in ASSERT must be defined.