Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intrinsifier.h

Issue 11421024: Use fingerprint to detect changes in methods that are intrinsified. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.h
===================================================================
--- runtime/vm/intrinsifier.h (revision 15200)
+++ runtime/vm/intrinsifier.h (working copy)
@@ -10,89 +10,97 @@
namespace dart {
-// List of intrinsics: (class-name, function-name, intrinsification method).
+// List of intrinsics:
+// (class-name, function-name, intrinsification method, fingerprint).
+//
+// When adding a new function for intrinsification add a 0 as fingerprint,
+// build and run to get the correct fingerprint from the mismatch error.
#define INTRINSIC_LIST(V) \
- V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger) \
- V(_IntegerImplementation, +, Integer_add) \
- V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger) \
- V(_IntegerImplementation, -, Integer_sub) \
- V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger) \
- V(_IntegerImplementation, *, Integer_mul) \
- V(_IntegerImplementation, %, Integer_modulo) \
- V(_IntegerImplementation, ~/, Integer_truncDivide) \
- V(_IntegerImplementation, unary-, Integer_negate) \
- V(_IntegerImplementation, _bitAndFromInteger, Integer_bitAndFromInteger) \
- V(_IntegerImplementation, &, Integer_bitAnd) \
- V(_IntegerImplementation, _bitOrFromInteger, Integer_bitOrFromInteger) \
- V(_IntegerImplementation, |, Integer_bitOr) \
- V(_IntegerImplementation, _bitXorFromInteger, Integer_bitXorFromInteger) \
- V(_IntegerImplementation, ^, Integer_bitXor) \
+ V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger, 726019207)\
+ V(_IntegerImplementation, +, Integer_add, 13708438) \
+ V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger, 726019207)\
+ V(_IntegerImplementation, -, Integer_sub, 284482664) \
+ V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger, 726019207)\
+ V(_IntegerImplementation, *, Integer_mul, 486761895) \
+ V(_IntegerImplementation, %, Integer_modulo, 1370017357) \
+ V(_IntegerImplementation, ~/, Integer_truncDivide, 450435650) \
+ V(_IntegerImplementation, unary-, Integer_negate, 1734168384) \
+ V(_IntegerImplementation, _bitAndFromInteger, \
+ Integer_bitAndFromInteger, 726019207) \
+ V(_IntegerImplementation, &, Integer_bitAnd, 1267520437) \
+ V(_IntegerImplementation, _bitOrFromInteger, \
+ Integer_bitOrFromInteger, 726019207) \
+ V(_IntegerImplementation, |, Integer_bitOr, 249432836) \
+ V(_IntegerImplementation, _bitXorFromInteger, \
+ Integer_bitXorFromInteger, 726019207) \
+ V(_IntegerImplementation, ^, Integer_bitXor, 1177061571) \
V(_IntegerImplementation, \
_greaterThanFromInteger, \
- Integer_greaterThanFromInt) \
- V(_IntegerImplementation, >, Integer_greaterThan) \
- V(_IntegerImplementation, ==, Integer_equal) \
- V(_IntegerImplementation, _equalToInteger, Integer_equalToInteger) \
- V(_IntegerImplementation, <, Integer_lessThan) \
- V(_IntegerImplementation, <=, Integer_lessEqualThan) \
- V(_IntegerImplementation, >=, Integer_greaterEqualThan) \
- V(_IntegerImplementation, <<, Integer_shl) \
- V(_IntegerImplementation, >>, Integer_sar) \
- V(_Smi, ~, Smi_bitNegate) \
- V(_Double, >, Double_greaterThan) \
- V(_Double, >=, Double_greaterEqualThan) \
- V(_Double, <, Double_lessThan) \
- V(_Double, <=, Double_lessEqualThan) \
- V(_Double, ==, Double_equal) \
- V(_Double, +, Double_add) \
- V(_Double, -, Double_sub) \
- V(_Double, *, Double_mul) \
- V(_Double, /, Double_div) \
- V(_Double, get:isNaN, Double_getIsNaN) \
- V(_Double, get:isNegative, Double_getIsNegative) \
- V(_Double, _mulFromInteger, Double_mulFromInteger) \
- V(_Double, .fromInteger, Double_fromInteger) \
- V(_Double, toInt, Double_toInt) \
- V(_ObjectArray, ., ObjectArray_Allocate) \
- V(_ObjectArray, get:length, Array_getLength) \
- V(_ObjectArray, [], Array_getIndexed) \
- V(_ObjectArray, []=, Array_setIndexed) \
- V(_GrowableObjectArray, .fromObjectArray, GArray_Allocate) \
- V(_GrowableObjectArray, get:length, GrowableArray_getLength) \
- V(_GrowableObjectArray, get:capacity, GrowableArray_getCapacity) \
- V(_GrowableObjectArray, [], GrowableArray_getIndexed) \
- V(_GrowableObjectArray, []=, GrowableArray_setIndexed) \
- V(_GrowableObjectArray, _setLength, GrowableArray_setLength) \
- V(_GrowableObjectArray, _setData, GrowableArray_setData) \
- V(_GrowableObjectArray, add, GrowableArray_add) \
- V(_ImmutableArray, [], ImmutableArray_getIndexed) \
- V(_ImmutableArray, get:length, ImmutableArray_getLength) \
- V(::, sqrt, Math_sqrt) \
- V(::, sin, Math_sin) \
- V(::, cos, Math_cos) \
- V(Object, ==, Object_equal) \
- V(_FixedSizeArrayIterator, get:hasNext, FixedSizeArrayIterator_getHasNext) \
- V(_FixedSizeArrayIterator, next, FixedSizeArrayIterator_next) \
- V(_StringBase, get:hashCode, String_getHashCode) \
- V(_StringBase, get:isEmpty, String_getIsEmpty) \
- V(_StringBase, get:length, String_getLength) \
- V(_StringBase, charCodeAt, String_charCodeAt) \
- V(_ByteArrayBase, get:length, ByteArrayBase_getLength) \
- V(_Int8Array, [], Int8Array_getIndexed) \
- V(_Int8Array, []=, Int8Array_setIndexed) \
- V(_Uint8Array, [], Uint8Array_getIndexed) \
- V(_Uint8Array, []=, Uint8Array_setIndexed) \
- V(_Int16Array, [], Int16Array_getIndexed) \
- V(_Uint16Array, [], Uint16Array_getIndexed) \
- V(_Int32Array, [], Int32Array_getIndexed) \
- V(_Uint32Array, [], Uint32Array_getIndexed) \
- V(_Int64Array, [], Int64Array_getIndexed) \
- V(_Uint64Array, [], Uint64Array_getIndexed) \
- V(_Float32Array, [], Float32Array_getIndexed) \
- V(_Float32Array, []=, Float32Array_setIndexed) \
- V(_Float64Array, [], Float64Array_getIndexed) \
- V(_Float64Array, []=, Float64Array_setIndexed) \
- V(_ExternalUint8Array, [], ExternalUint8Array_getIndexed) \
+ Integer_greaterThanFromInt, 79222670) \
+ V(_IntegerImplementation, >, Integer_greaterThan, 319553701) \
+ V(_IntegerImplementation, ==, Integer_equal, 1163202222) \
+ V(_IntegerImplementation, _equalToInteger, Integer_equalToInteger, 79222670) \
+ V(_IntegerImplementation, <, Integer_lessThan, 1306209983) \
+ V(_IntegerImplementation, <=, Integer_lessEqualThan, 458673122) \
+ V(_IntegerImplementation, >=, Integer_greaterEqualThan, 459596643) \
+ V(_IntegerImplementation, <<, Integer_shl, 1586407617) \
+ V(_IntegerImplementation, >>, Integer_sar, 130211175) \
+ V(_Smi, ~, Smi_bitNegate, 882629793) \
+ V(_Double, >, Double_greaterThan, 1821658410) \
+ V(_Double, >=, Double_greaterEqualThan, 1317118885) \
+ V(_Double, <, Double_lessThan, 177557761) \
+ V(_Double, <=, Double_lessEqualThan, 1316195364) \
+ V(_Double, ==, Double_equal, 1896071176) \
+ V(_Double, +, Double_add, 1137022234) \
+ V(_Double, -, Double_sub, 1425469940) \
+ V(_Double, *, Double_mul, 1865672692) \
+ V(_Double, /, Double_div, 1832148629) \
+ V(_Double, get:isNaN, Double_getIsNaN, 54462366) \
+ V(_Double, get:isNegative, Double_getIsNegative, 54462366) \
+ V(_Double, _mulFromInteger, Double_mulFromInteger, 795128) \
+ V(_Double, .fromInteger, Double_fromInteger, 842078193) \
+ V(_Double, toInt, Double_toInt, 362666636) \
+ V(_ObjectArray, ., ObjectArray_Allocate, 577949617) \
+ V(_ObjectArray, get:length, Array_getLength, 405297088) \
+ V(_ObjectArray, [], Array_getIndexed, 71937385) \
+ V(_ObjectArray, []=, Array_setIndexed, 255863719) \
+ V(_GrowableObjectArray, .fromObjectArray, GArray_Allocate, 989879928) \
+ V(_GrowableObjectArray, get:length, GrowableArray_getLength, 725548050) \
+ V(_GrowableObjectArray, get:capacity, GrowableArray_getCapacity, 725548050) \
+ V(_GrowableObjectArray, [], GrowableArray_getIndexed, 581838973) \
+ V(_GrowableObjectArray, []=, GrowableArray_setIndexed, 1048007636) \
+ V(_GrowableObjectArray, _setLength, GrowableArray_setLength, 796709584) \
+ V(_GrowableObjectArray, _setData, GrowableArray_setData, 477312179) \
+ V(_GrowableObjectArray, add, GrowableArray_add, 1776744235) \
+ V(_ImmutableArray, [], ImmutableArray_getIndexed, 486821199) \
+ V(_ImmutableArray, get:length, ImmutableArray_getLength, 433698233) \
+ V(::, sqrt, Math_sqrt, 2232519) \
+ V(::, sin, Math_sin, 837187616) \
+ V(::, cos, Math_cos, 548880317) \
+ V(Object, ==, Object_equal, 1512068535) \
+ V(_FixedSizeArrayIterator, get:hasNext, \
+ FixedSizeArrayIterator_getHasNext, 1847855366) \
+ V(_FixedSizeArrayIterator, next, FixedSizeArrayIterator_next, 1739352783) \
+ V(_StringBase, get:hashCode, String_getHashCode, 320803993) \
+ V(_StringBase, get:isEmpty, String_getIsEmpty, 1065961093) \
+ V(_StringBase, get:length, String_getLength, 320803993) \
+ V(_StringBase, charCodeAt, String_charCodeAt, 984449525) \
+ V(_ByteArrayBase, get:length, ByteArrayBase_getLength, 1856909152) \
+ V(_Int8Array, [], Int8Array_getIndexed, 239810357) \
+ V(_Int8Array, []=, Int8Array_setIndexed, 1469038436) \
+ V(_Uint8Array, [], Uint8Array_getIndexed, 1635923899) \
+ V(_Uint8Array, []=, Uint8Array_setIndexed, 1619321522) \
+ V(_Int16Array, [], Int16Array_getIndexed, 2090761657) \
+ V(_Uint16Array, [], Uint16Array_getIndexed, 289929708) \
+ V(_Int32Array, [], Int32Array_getIndexed, 589442411) \
+ V(_Uint32Array, [], Uint32Array_getIndexed, 1474116947) \
+ V(_Int64Array, [], Int64Array_getIndexed, 1506836119) \
+ V(_Uint64Array, [], Uint64Array_getIndexed, 1856952148) \
+ V(_Float32Array, [], Float32Array_getIndexed, 1167607283) \
+ V(_Float32Array, []=, Float32Array_setIndexed, 1270729544) \
+ V(_Float64Array, [], Float64Array_getIndexed, 1363897161) \
+ V(_Float64Array, []=, Float64Array_setIndexed, 283625119) \
+ V(_ExternalUint8Array, [], ExternalUint8Array_getIndexed, 632699940) \
// Forward declarations.
class Assembler;
@@ -107,7 +115,7 @@
static bool CanIntrinsify(const Function& function);
private:
-#define DECLARE_FUNCTION(test_class_name, test_function_name, destination) \
+#define DECLARE_FUNCTION(test_class_name, test_function_name, destination, fp) \
static bool destination(Assembler* assembler);
INTRINSIC_LIST(DECLARE_FUNCTION)
« no previous file with comments | « no previous file | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698