runtime/vm/intrinsifier.h - Issue 11421024: Use fingerprint to detect changes in methods that are intrinsified.

Side by Side Diff: runtime/vm/intrinsifier.h

Issue 11421024: Use fingerprint to detect changes in methods that are intrinsified. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4 // Class for intrinsifying functions.	4 // Class for intrinsifying functions.

5	5

6 #ifndef VM_INTRINSIFIER_H_	6 #ifndef VM_INTRINSIFIER_H_

7 #define VM_INTRINSIFIER_H_	7 #define VM_INTRINSIFIER_H_

8	8

9 #include "vm/allocation.h"	9 #include "vm/allocation.h"

10	10

11 namespace dart {	11 namespace dart {

12	12

13 // List of intrinsics: (class-name, function-name, intrinsification method).	13 // List of intrinsics: (class-name, function-name, intrinsification method).
	siva 2012/11/21 17:33:14 Could you add a comment here which states how one Could you add a comment here which states how one should go about updating the value when they add a new function or make modifications to an intrinsified method. e.g: When adding a new function for intrinsification add a 0 for the value and do the build, we should see a fingerprint mismatch error. Take the expected value and plug it in here..... or something like that. srdjan 2012/11/21 18:11:14 Done. Show quoted text On 2012/11/21 17:33:14, siva wrote: > Could you add a comment here which states how one should > go about updating the value when they add a new function or > make modifications to an intrinsified method. > > e.g: When adding a new function for intrinsification > add a 0 for the value and do the build, we should see a > fingerprint mismatch error. Take the expected value and > plug it in here..... or something like that. Done.
14 #define INTRINSIC_LIST(V) \	14 #define INTRINSIC_LIST(V) \

15 V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger) \	15 V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger, 251256260)\

16 V(_IntegerImplementation, +, Integer_add) \	16 V(_IntegerImplementation, +, Integer_add, 1417559919) \

17 V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger) \	17 V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger, 251256260)\

18 V(_IntegerImplementation, -, Integer_sub) \	18 V(_IntegerImplementation, -, Integer_sub, 1150734756) \

19 V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger) \	19 V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger, 251256260)\

20 V(_IntegerImplementation, *, Integer_mul) \	20 V(_IntegerImplementation, *, Integer_mul, -899298142) \

21 V(_IntegerImplementation, %, Integer_modulo) \	21 V(_IntegerImplementation, %, Integer_modulo, -1865131747) \

22 V(_IntegerImplementation, ~/, Integer_truncDivide) \	22 V(_IntegerImplementation, ~/, Integer_truncDivide, 2007920794) \

23 V(_IntegerImplementation, unary-, Integer_negate) \	23 V(_IntegerImplementation, unary-, Integer_negate, 905573019) \

24 V(_IntegerImplementation, _bitAndFromInteger, Integer_bitAndFromInteger) \	24 V(_IntegerImplementation, _bitAndFromInteger, \

25 V(_IntegerImplementation, &, Integer_bitAnd) \	25 Integer_bitAndFromInteger, 251256260) \

26 V(_IntegerImplementation, _bitOrFromInteger, Integer_bitOrFromInteger) \	26 V(_IntegerImplementation, &, Integer_bitAnd, -1072960524) \

27 V(_IntegerImplementation, \|, Integer_bitOr) \	27 V(_IntegerImplementation, _bitOrFromInteger, \

28 V(_IntegerImplementation, _bitXorFromInteger, Integer_bitXorFromInteger) \	28 Integer_bitOrFromInteger, 251256260) \

29 V(_IntegerImplementation, ^, Integer_bitXor) \	29 V(_IntegerImplementation, \|, Integer_bitOr, -1181001630) \

	30 V(_IntegerImplementation, _bitXorFromInteger, \

	31 Integer_bitXorFromInteger, 251256260) \

	32 V(_IntegerImplementation, ^, Integer_bitXor, 303332176) \

30 V(_IntegerImplementation, \	33 V(_IntegerImplementation, \

31 _greaterThanFromInteger, \	34 _greaterThanFromInteger, \

32 Integer_greaterThanFromInt) \	35 Integer_greaterThanFromInt, 343609773) \

33 V(_IntegerImplementation, >, Integer_greaterThan) \	36 V(_IntegerImplementation, >, Integer_greaterThan, 1527949912) \

34 V(_IntegerImplementation, ==, Integer_equal) \	37 V(_IntegerImplementation, ==, Integer_equal, -1350503895) \

35 V(_IntegerImplementation, _equalToInteger, Integer_equalToInteger) \	38 V(_IntegerImplementation, _equalToInteger, Integer_equalToInteger, 343609773)\

36 V(_IntegerImplementation, <, Integer_lessThan) \	39 V(_IntegerImplementation, <, Integer_lessThan, 1161534824) \

37 V(_IntegerImplementation, <=, Integer_lessEqualThan) \	40 V(_IntegerImplementation, <=, Integer_lessEqualThan, 1181026147) \

38 V(_IntegerImplementation, >=, Integer_greaterEqualThan) \	41 V(_IntegerImplementation, >=, Integer_greaterEqualThan, 1181949668) \

39 V(_IntegerImplementation, <<, Integer_shl) \	42 V(_IntegerImplementation, <<, Integer_shl, 1979635198) \

40 V(_IntegerImplementation, >>, Integer_sar) \	43 V(_IntegerImplementation, >>, Integer_sar, 873831233) \

41 V(_Smi, ~, Smi_bitNegate) \	44 V(_Smi, ~, Smi_bitNegate, 182612692) \

42 V(_Double, >, Double_greaterThan) \	45 V(_Double, >, Double_greaterThan, 732406301) \

43 V(_Double, >=, Double_greaterEqualThan) \	46 V(_Double, >=, Double_greaterEqualThan, 557396553) \

44 V(_Double, <, Double_lessThan) \	47 V(_Double, <, Double_lessThan, -808852019) \

45 V(_Double, <=, Double_lessEqualThan) \	48 V(_Double, <=, Double_lessEqualThan, 556473032) \

46 V(_Double, ==, Double_equal) \	49 V(_Double, ==, Double_equal, -1660073600) \

47 V(_Double, +, Double_add) \	50 V(_Double, +, Double_add, -1090474446) \

48 V(_Double, -, Double_sub) \	51 V(_Double, -, Double_sub, 1652466173) \

49 V(_Double, *, Double_mul) \	52 V(_Double, *, Double_mul, -691456856) \

50 V(_Double, /, Double_div) \	53 V(_Double, /, Double_div, -203533943) \

51 V(_Double, get:isNaN, Double_getIsNaN) \	54 V(_Double, get:isNaN, Double_getIsNaN, 185842349) \

52 V(_Double, get:isNegative, Double_getIsNegative) \	55 V(_Double, get:isNegative, Double_getIsNegative, 185842349) \

53 V(_Double, _mulFromInteger, Double_mulFromInteger) \	56 V(_Double, _mulFromInteger, Double_mulFromInteger, 2082126982) \

54 V(_Double, .fromInteger, Double_fromInteger) \	57 V(_Double, .fromInteger, Double_fromInteger, 362680409) \

55 V(_Double, toInt, Double_toInt) \	58 V(_Double, toInt, Double_toInt, 184965894) \

56 V(_ObjectArray, ., ObjectArray_Allocate) \	59 V(_ObjectArray, ., ObjectArray_Allocate, 516414775) \

57 V(_ObjectArray, get:length, Array_getLength) \	60 V(_ObjectArray, get:length, Array_getLength, 505691645) \

58 V(_ObjectArray, [], Array_getIndexed) \	61 V(_ObjectArray, [], Array_getIndexed, 382220560) \

59 V(_ObjectArray, []=, Array_setIndexed) \	62 V(_ObjectArray, []=, Array_setIndexed, 897266289) \

60 V(_GrowableObjectArray, .fromObjectArray, GArray_Allocate) \	63 V(_GrowableObjectArray, .fromObjectArray, GArray_Allocate, 970568289) \

61 V(_GrowableObjectArray, get:length, GrowableArray_getLength) \	64 V(_GrowableObjectArray, get:length, GrowableArray_getLength, 292544643) \

62 V(_GrowableObjectArray, get:capacity, GrowableArray_getCapacity) \	65 V(_GrowableObjectArray, get:capacity, GrowableArray_getCapacity, 292544643) \

63 V(_GrowableObjectArray, [], GrowableArray_getIndexed) \	66 V(_GrowableObjectArray, [], GrowableArray_getIndexed, 1067175750) \

64 V(_GrowableObjectArray, []=, GrowableArray_setIndexed) \	67 V(_GrowableObjectArray, []=, GrowableArray_setIndexed, 334972801) \

65 V(_GrowableObjectArray, _setLength, GrowableArray_setLength) \	68 V(_GrowableObjectArray, _setLength, GrowableArray_setLength, 542523850) \

66 V(_GrowableObjectArray, _setData, GrowableArray_setData) \	69 V(_GrowableObjectArray, _setData, GrowableArray_setData, 551809123) \

67 V(_GrowableObjectArray, add, GrowableArray_add) \	70 V(_GrowableObjectArray, add, GrowableArray_add, -916291117) \

68 V(_ImmutableArray, [], ImmutableArray_getIndexed) \	71 V(_ImmutableArray, [], ImmutableArray_getIndexed, 942056078) \

69 V(_ImmutableArray, get:length, ImmutableArray_getLength) \	72 V(_ImmutableArray, get:length, ImmutableArray_getLength, 308481413) \

70 V(::, sqrt, Math_sqrt) \	73 V(::, sqrt, Math_sqrt, -399054335) \

71 V(::, sin, Math_sin) \	74 V(::, sin, Math_sin, -718061403) \

72 V(::, cos, Math_cos) \	75 V(::, cos, Math_cos, -353024741) \

73 V(Object, ==, Object_equal) \	76 V(Object, ==, Object_equal, 614523899) \

74 V(_FixedSizeArrayIterator, get:hasNext, FixedSizeArrayIterator_getHasNext) \	77 V(_FixedSizeArrayIterator, get:hasNext, \

75 V(_FixedSizeArrayIterator, next, FixedSizeArrayIterator_next) \	78 FixedSizeArrayIterator_getHasNext, 813218036) \

76 V(_StringBase, get:hashCode, String_getHashCode) \	79 V(_FixedSizeArrayIterator, next, FixedSizeArrayIterator_next, -537498242) \

77 V(_StringBase, get:isEmpty, String_getIsEmpty) \	80 V(_StringBase, get:hashCode, String_getHashCode, 580805373) \

78 V(_StringBase, get:length, String_getLength) \	81 V(_StringBase, get:isEmpty, String_getIsEmpty, -1707596587) \

79 V(_StringBase, charCodeAt, String_charCodeAt) \	82 V(_StringBase, get:length, String_getLength, 580805373) \

80 V(_ByteArrayBase, get:length, ByteArrayBase_getLength) \	83 V(_StringBase, charCodeAt, String_charCodeAt, 1008192499) \

81 V(_Int8Array, [], Int8Array_getIndexed) \	84 V(_ByteArrayBase, get:length, ByteArrayBase_getLength, 737779092) \

82 V(_Int8Array, []=, Int8Array_setIndexed) \	85 V(_Int8Array, [], Int8Array_getIndexed, -1020904427) \

83 V(_Uint8Array, [], Uint8Array_getIndexed) \	86 V(_Int8Array, []=, Int8Array_setIndexed, 1174765536) \

84 V(_Uint8Array, []=, Uint8Array_setIndexed) \	87 V(_Uint8Array, [], Uint8Array_getIndexed, 1586516743) \

85 V(_Int16Array, [], Int16Array_getIndexed) \	88 V(_Uint8Array, []=, Uint8Array_setIndexed, -925317545) \

86 V(_Uint16Array, [], Uint16Array_getIndexed) \	89 V(_Int16Array, [], Int16Array_getIndexed, -102624255) \

87 V(_Int32Array, [], Int32Array_getIndexed) \	90 V(_Uint16Array, [], Uint16Array_getIndexed, 293364560) \

88 V(_Uint32Array, [], Uint32Array_getIndexed) \	91 V(_Int32Array, [], Int32Array_getIndexed, -616228689) \

89 V(_Int64Array, [], Int64Array_getIndexed) \	92 V(_Uint32Array, [], Uint32Array_getIndexed, -605453562) \

90 V(_Uint64Array, [], Uint64Array_getIndexed) \	93 V(_Int64Array, [], Int64Array_getIndexed, -1377240646) \

91 V(_Float32Array, [], Float32Array_getIndexed) \	94 V(_Uint64Array, [], Uint64Array_getIndexed, 11017107) \

92 V(_Float32Array, []=, Float32Array_setIndexed) \	95 V(_Float32Array, [], Float32Array_getIndexed, -1744696611) \

93 V(_Float64Array, [], Float64Array_getIndexed) \	96 V(_Float32Array, []=, Float32Array_setIndexed, 501958413) \

94 V(_Float64Array, []=, Float64Array_setIndexed) \	97 V(_Float64Array, [], Float64Array_getIndexed, 1250156783) \

	98 V(_Float64Array, []=, Float64Array_setIndexed, 574475363) \

95	99

96 // Forward declarations.	100 // Forward declarations.

97 class Assembler;	101 class Assembler;

98 class Function;	102 class Function;

99	103

100 class Intrinsifier : public AllStatic {	104 class Intrinsifier : public AllStatic {

101 public:	105 public:

102 // Try to intrinsify 'function'. Returns true if the function intrinsified	106 // Try to intrinsify 'function'. Returns true if the function intrinsified

103 // completely and the code does not need to be generated (i.e., no slow	107 // completely and the code does not need to be generated (i.e., no slow

104 // path possible).	108 // path possible).

105 static bool Intrinsify(const Function& function, Assembler* assembler);	109 static bool Intrinsify(const Function& function, Assembler* assembler);

106 static bool CanIntrinsify(const Function& function);	110 static bool CanIntrinsify(const Function& function);

107	111

108 private:	112 private:

109 #define DECLARE_FUNCTION(test_class_name, test_function_name, destination) \	113 #define DECLARE_FUNCTION(test_class_name, test_function_name, destination, fp) \

110 static bool destination(Assembler* assembler);	114 static bool destination(Assembler* assembler);

111	115

112 INTRINSIC_LIST(DECLARE_FUNCTION)	116 INTRINSIC_LIST(DECLARE_FUNCTION)

113 #undef DECLARE_FUNCTION	117 #undef DECLARE_FUNCTION

114 };	118 };

115	119

116 } // namespace dart	120 } // namespace dart

117	121

118 #endif // VM_INTRINSIFIER_H_	122 #endif // VM_INTRINSIFIER_H_

OLD	NEW

« no previous file with comments | « no previous file | runtime/vm/intrinsifier.cc » ('j') | runtime/vm/intrinsifier.cc » ('J')