Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 11419089: Pass --minify to dart2dart if --minified was specified on test.py (Closed)

Created:
8 years, 1 month ago by kustermann
Modified:
8 years, 1 month ago
Reviewers:
ricow1, ahe, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pass --minify to dart2dart if --minified was specified on test.py Currently --minified on test.py has only an effect on dart2js commands. The dart2dart commands use the legacy --additional-compiler-flags="--minify" option. This change is the first one of two CLs, where we pass --minify to dart2dart if --minified was specified on test.py. The second change will then remove the --additional-compiler-flags option as soon as the build bots have been updated to use the new scheme for dart2dart. Committed: https://code.google.com/p/dart/source/detail?r=15144

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
kustermann
8 years, 1 month ago (2012-11-20 11:15:09 UTC) #1
ricow1
+antonm
8 years, 1 month ago (2012-11-20 11:37:37 UTC) #2
ricow1
LGTM https://codereview.chromium.org/11419089/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/11419089/diff/1/tools/testing/dart/test_suite.dart#newcode1591 tools/testing/dart/test_suite.dart:1591: configuration["minified"]) { I think you can safely change ...
8 years, 1 month ago (2012-11-20 11:38:39 UTC) #3
Anton Muhin
lgtm
8 years, 1 month ago (2012-11-20 11:42:57 UTC) #4
ahe
8 years, 1 month ago (2012-11-23 07:58:00 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698