Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11419089: Pass --minify to dart2dart if --minified was specified on test.py (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1569 matching lines...) Expand 10 before | Expand all | Expand 10 after
1580 if (compiler == "dart2js" || compiler == "dart2dart") { 1580 if (compiler == "dart2js" || compiler == "dart2dart") {
1581 args = []; 1581 args = [];
1582 if (configuration["checked"]) { 1582 if (configuration["checked"]) {
1583 args.add('--enable-checked-mode'); 1583 args.add('--enable-checked-mode');
1584 } 1584 }
1585 // args.add("--verbose"); 1585 // args.add("--verbose");
1586 if (!isBrowserRuntime(configuration['runtime'])) { 1586 if (!isBrowserRuntime(configuration['runtime'])) {
1587 args.add("--allow-mock-compilation"); 1587 args.add("--allow-mock-compilation");
1588 } 1588 }
1589 } 1589 }
1590 // TODO(riocw): Unify our minification calling convention between dart2js 1590 if ((compiler == "dart2js" || compiler == "dart2dart") &&
1591 // and dart2dart. 1591 configuration["minified"]) {
ricow1 2012/11/20 11:38:39 I think you can safely change this to: if (configu
1592 if (compiler == "dart2js" && configuration["minified"]) {
1593 args.add("--minify"); 1592 args.add("--minify");
1594 } 1593 }
1595 return args; 1594 return args;
1596 } 1595 }
1597 1596
1598 static bool usesWebDriver(String runtime) { 1597 static bool usesWebDriver(String runtime) {
1599 const BROWSERS = const [ 1598 const BROWSERS = const [
1600 'dartium', 1599 'dartium',
1601 'ie9', 1600 'ie9',
1602 'ie10', 1601 'ie10',
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
1672 * $pass tests are expected to pass 1671 * $pass tests are expected to pass
1673 * $failOk tests are expected to fail that we won't fix 1672 * $failOk tests are expected to fail that we won't fix
1674 * $fail tests are expected to fail that we should fix 1673 * $fail tests are expected to fail that we should fix
1675 * $crash tests are expected to crash that we should fix 1674 * $crash tests are expected to crash that we should fix
1676 * $timeout tests are allowed to timeout 1675 * $timeout tests are allowed to timeout
1677 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1676 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1678 """; 1677 """;
1679 print(report); 1678 print(report);
1680 } 1679 }
1681 } 1680 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698