Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11419089: Pass --minify to dart2dart if --minified was specified on test.py (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index a26f877688d0a9781ced2add111cfe913006a66c..54abb58f65c5d8f6c7b26a321e48503a88f927be 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1587,9 +1587,8 @@ class TestUtils {
args.add("--allow-mock-compilation");
}
}
- // TODO(riocw): Unify our minification calling convention between dart2js
- // and dart2dart.
- if (compiler == "dart2js" && configuration["minified"]) {
+ if ((compiler == "dart2js" || compiler == "dart2dart") &&
+ configuration["minified"]) {
ricow1 2012/11/20 11:38:39 I think you can safely change this to: if (configu
args.add("--minify");
}
return args;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698