Issue 11412306: Hacky fix for paths with drive names on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412306: Hacky fix for paths with drive names on Windows. (Closed)

Created:
8 years ago by Anton Muhin

Modified:
8 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Hacky fix for paths with drive names on Windows. TBR=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=15654

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years ago (2012-12-04 12:50:38 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/11412306/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11412306/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1522: continue;
This is fixed in a later CL.

The key thing is that the paths were actually being created properly, I think,
but the directory check should not be done on the path /E:, only on the path
/E:/b, etc.  So we just want the continue, so it really could just be

base = base.append(segment);
if (segment =2 and = .:) continue;

Remember that Directory.fromPath() uses toNativePath, so that the leading / is
stripped there, and should actually be on the path.

Expand Messages | Collapse Messages