Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11412306: Hacky fix for paths with drive names on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 5e6c97daa7928ffe2bd758940caeb93275cef52f..389c19d2030430e4579a557cc2ea9b9f1017e553 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1515,6 +1515,12 @@ class TestUtils {
"Expected ${dir} to already exist");
var segments = relativePath.segments();
for (String segment in segments) {
+ // Ugly hack: if Windows absolute path starts with a drive,
+ // rewrite [base] properly.
+ if (segment.length == 2 && segment.endsWith(':')) {
+ base = segment + '\\';
+ continue;
Bill Hesse 2012/12/04 12:50:38 This is fixed in a later CL. The key thing is tha
+ }
base = base.append(segment);
dir = new Directory.fromPath(base);
if (!dir.existsSync()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698