Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11412306: Hacky fix for paths with drive names on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1497 matching lines...) Expand 10 before | Expand all | Expand 10 after
1508 static Directory mkdirRecursive(Path base, Path relativePath) { 1508 static Directory mkdirRecursive(Path base, Path relativePath) {
1509 print("======= $base|$relativePath|${relativePath.isAbsolute}|${relativePath .segments()}"); 1509 print("======= $base|$relativePath|${relativePath.isAbsolute}|${relativePath .segments()}");
1510 if (relativePath.isAbsolute) { 1510 if (relativePath.isAbsolute) {
1511 base = new Path('/'); 1511 base = new Path('/');
1512 } 1512 }
1513 Directory dir = new Directory.fromPath(base); 1513 Directory dir = new Directory.fromPath(base);
1514 Expect.isTrue(dir.existsSync(), 1514 Expect.isTrue(dir.existsSync(),
1515 "Expected ${dir} to already exist"); 1515 "Expected ${dir} to already exist");
1516 var segments = relativePath.segments(); 1516 var segments = relativePath.segments();
1517 for (String segment in segments) { 1517 for (String segment in segments) {
1518 // Ugly hack: if Windows absolute path starts with a drive,
1519 // rewrite [base] properly.
1520 if (segment.length == 2 && segment.endsWith(':')) {
1521 base = segment + '\\';
1522 continue;
Bill Hesse 2012/12/04 12:50:38 This is fixed in a later CL. The key thing is tha
1523 }
1518 base = base.append(segment); 1524 base = base.append(segment);
1519 dir = new Directory.fromPath(base); 1525 dir = new Directory.fromPath(base);
1520 if (!dir.existsSync()) { 1526 if (!dir.existsSync()) {
1521 dir.createSync(); 1527 dir.createSync();
1522 } 1528 }
1523 Expect.isTrue(dir.existsSync(), "Failed to create ${dir.path}"); 1529 Expect.isTrue(dir.existsSync(), "Failed to create ${dir.path}");
1524 } 1530 }
1525 return dir; 1531 return dir;
1526 } 1532 }
1527 1533
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1675 * $pass tests are expected to pass 1681 * $pass tests are expected to pass
1676 * $failOk tests are expected to fail that we won't fix 1682 * $failOk tests are expected to fail that we won't fix
1677 * $fail tests are expected to fail that we should fix 1683 * $fail tests are expected to fail that we should fix
1678 * $crash tests are expected to crash that we should fix 1684 * $crash tests are expected to crash that we should fix
1679 * $timeout tests are allowed to timeout 1685 * $timeout tests are allowed to timeout
1680 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1686 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1681 """; 1687 """;
1682 print(report); 1688 print(report);
1683 } 1689 }
1684 } 1690 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698