Issue 1140903002: Handle constant constructors with parse errors.

Issue 1140903002: Handle constant constructors with parse errors. (Closed)

Created:
5 years, 7 months ago by Johnni Winther

Modified:
5 years, 7 months ago

Reviewers:
karlklose, zarah

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Handle constant constructors with parse errors. co19/Language/07_Classes/07_Classes_A02_t13 exercises this. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/0afef600d452b67b2f9cffd14f31dc483c3d99ac

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -21 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/resolution/semantic_visitor.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/send_resolver.dart	View	1	3 chunks	+21 lines, -17 lines	0 comments	Download
M	tests/compiler/dart2js/semantic_visitor_test.dart	View	1	4 chunks	+69 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

Johnni Winther

PTAL; it turned out that we don't have a consistent way of marking non-constant constructor ...

5 years, 7 months ago (2015-05-13 11:19:03 UTC) #5

Johnni Winther

5 years, 7 months ago (2015-05-19 07:44:35 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
0afef600d452b67b2f9cffd14f31dc483c3d99ac (presubmit successful).