Handle constant constructors with parse errors.

tests/compiler/dart2js/semantic_visitor_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.semantics_visitor_test;
 
 import 'dart:async';
 import 'package:async_helper/async_helper.dart';
 import 'package:expect/expect.dart';
 import 'package:compiler/src/constants/expressions.dart';
@@ skipping 2440 matching lines @@
           factory Class(a, b) = AbstractClass;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
+    const Test(
+        '''
+        class Class {}
+        m() => const Class();
+        ''',
+        const Visit(VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+            arguments: '()',
+            type: 'Class',
+            selector: 'CallStructure(arity=0)')),
+    const Test(
+        '''
+        class Class {
+          const Class() // Delibrate syntax error.
+        }
+        m() => const Class();
+        ''',
+        const Visit(VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+            arguments: '()',
+            type: 'dynamic',
+            selector: 'CallStructure(arity=0)')),
+    const Test(
+        '''
+        class Target {}
+        class Class {
+          const factory Class() = Target;
+        }
+        m() => const Class();
+        ''',
+        const Visit(VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+            arguments: '()',
+            type: 'Class',
+            selector: 'CallStructure(arity=0)')),
+    /* Enable this when constness is handled consistently.
+    const Test(
+        '''
+        class Target {
+          const Target();
+        }
+        class Redirection {
+          factory Redirection() = Target;
+        }
+        class Class {
+          const factory Class() = Redirection;
+        }
+        m() => const Class();
+        ''',
+        const Visit(VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+            arguments: '()',
+            type: 'Class',
+            selector: 'CallStructure(arity=0)')),
+    */
   ],
 };
 
 const Map<String, List<Test>> DECL_TESTS = const {
   'Function declarations': const [
     const Test(
         '''
         m(a, b) {}
         ''',
         const [
@@ skipping 846 matching lines @@
       }
 
       String filename = 'lib$index.dart';
       testSource.writeln(test.code);
       sourceFiles[filename] = testSource.toString();
       mainSource.writeln("import '$filename';");
       testMap[filename] = test;
       index++;
     });
   });
+
   mainSource.writeln("main() {}");
   sourceFiles['main.dart'] = mainSource.toString();
 
   Compiler compiler = compilerFor(sourceFiles,
       options: ['--analyze-all', '--analyze-only']);
   return compiler.run(Uri.parse('memory:main.dart')).then((_) {
     testMap.forEach((String filename, Test test) {
       LibraryElement library = compiler.libraryLoader.lookupLibrary(
           Uri.parse('memory:$filename'));
       var expectedVisits = test.expectedVisits;
@@ skipping 2245 matching lines @@
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(
         VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
         selector: callStructure));
     apply(arguments, arg);
   }
+
+  @override
+  errorNonConstantConstructorInvoke(
+      NewExpression node,
+      Element element,
+      DartType type,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(
+        VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+        type: type,
+        arguments: arguments,
+        selector: callStructure));
+    apply(arguments, arg);
+  }
 }
 
 class SemanticDeclarationTestVisitor extends SemanticTestVisitor {
 
   SemanticDeclarationTestVisitor(TreeElements elements) : super(elements);
 
   @override
   errorUnresolvedSuperConstructorInvoke(
       Send node,
       Element element,
@@ skipping 808 matching lines @@
   VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
 
   VISIT_SUPER_CONSTRUCTOR_INVOKE,
   VISIT_THIS_CONSTRUCTOR_INVOKE,
   VISIT_FIELD_INITIALIZER,
 
   VISIT_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
   VISIT_UNRESOLVED_CONSTRUCTOR_INVOKE,
   VISIT_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
   VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+  ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
 
   VISIT_INSTANCE_GETTER_DECL,
   VISIT_INSTANCE_SETTER_DECL,
   VISIT_INSTANCE_METHOD_DECL,
   VISIT_ABSTRACT_GETTER_DECL,
   VISIT_ABSTRACT_SETTER_DECL,
   VISIT_ABSTRACT_METHOD_DECL,
   VISIT_INSTANCE_FIELD_DECL,
 
   VISIT_GENERATIVE_CONSTRUCTOR_DECL,
   VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_DECL,
   VISIT_FACTORY_CONSTRUCTOR_DECL,
   VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_DECL,
 
   VISIT_REQUIRED_PARAMETER_DECL,
   VISIT_OPTIONAL_PARAMETER_DECL,
   VISIT_NAMED_PARAMETER_DECL,
   VISIT_REQUIRED_INITIALIZING_FORMAL_DECL,
   VISIT_OPTIONAL_INITIALIZING_FORMAL_DECL,
   VISIT_NAMED_INITIALIZING_FORMAL_DECL,
 
   ERROR_UNRESOLVED_POSTFIX,
 
   // TODO(johnniwinther): Add tests for more error cases.
 }