Handle constant constructors with parse errors.

pkg/compiler/lib/src/resolution/send_resolver.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor;
 
 enum SendStructureKind {
   GET,
   SET,
   INVOKE,
@@ skipping 412 matching lines @@
         // This happens for code like `C.this`.
         return new StaticAccess.unresolved(null);
       } else {
         return handleStaticallyResolvedAccess(node, element, getter);
       }
     }
   }
 
   ConstructorAccessSemantics computeConstructorAccessSemantics(
         ConstructorElement constructor,
-        DartType type) {
+        DartType type,
+        {bool mustBeConstant: false}) {
+    if (mustBeConstant && !constructor.isConst) {
+      return new ConstructorAccessSemantics(
+          ConstructorAccessKind.NON_CONSTANT_CONSTRUCTOR, constructor, type);
+    }
     if (constructor.isErroneous) {
       if (constructor is ErroneousElement) {
         ErroneousElement error = constructor;
         if (error.messageKind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
           return new ConstructorAccessSemantics(
               ConstructorAccessKind.UNRESOLVED_CONSTRUCTOR, constructor, type);
         }
       }
       return new ConstructorAccessSemantics(
           ConstructorAccessKind.UNRESOLVED_TYPE, constructor, type);
     } else if (constructor.isRedirectingFactory) {
       ConstructorElement effectiveTarget = constructor.effectiveTarget;
       if (effectiveTarget == constructor ||
-          effectiveTarget.isErroneous) {
+          effectiveTarget.isErroneous ||
+          (mustBeConstant && !effectiveTarget.isConst)) {
         return new ConstructorAccessSemantics(
             ConstructorAccessKind.ERRONEOUS_REDIRECTING_FACTORY,
             constructor,
             type);
       }
       ConstructorAccessSemantics effectiveTargetSemantics =
           computeConstructorAccessSemantics(
               effectiveTarget,
               constructor.computeEffectiveTargetType(type));
       if (effectiveTargetSemantics.isErroneous) {
@@ skipping 21 matching lines @@
     } else if (constructor.enclosingClass.isAbstract) {
       return new ConstructorAccessSemantics(
           ConstructorAccessKind.ABSTRACT, constructor, type);
     } else {
       return new ConstructorAccessSemantics(
           ConstructorAccessKind.GENERATIVE, constructor, type);
     }
   }
 
   NewStructure computeNewStructure(NewExpression node) {
-    if (node.isConst) {
-      ConstantExpression constant = elements.getConstant(node);
-      if (constant is ConstructedConstantExpression) {
-        return new ConstInvokeStructure(constant);
-      }
-    }
-
     Element element = elements[node.send];
     Selector selector = elements.getSelector(node.send);
     DartType type = elements.getType(node);
 
-    ConstructorAccessSemantics constructorAccessSemantics;
+    ConstructorAccessSemantics constructorAccessSemantics =
+        computeConstructorAccessSemantics(
+            element, type, mustBeConstant: node.isConst);
     if (node.isConst) {
-      // This is a non-constant constant constructor invocation, like
-      // `const Const(method())`.
-      constructorAccessSemantics = new ConstructorAccessSemantics(
-          ConstructorAccessKind.NON_CONSTANT_CONSTRUCTOR, element, type);
-    } else {
-      constructorAccessSemantics =
-          computeConstructorAccessSemantics(element, type);
+      ConstantExpression constant = elements.getConstant(node);
+      if (constructorAccessSemantics.isErroneous ||
+          constant is! ConstructedConstantExpression) {
+        // This is a non-constant constant constructor invocation, like
+        // `const Const(method())`.
+        constructorAccessSemantics = new ConstructorAccessSemantics(
+            ConstructorAccessKind.NON_CONSTANT_CONSTRUCTOR, element, type);
+      } else {
+        return new ConstInvokeStructure(constant);
+      }
     }
     return new NewInvokeStructure(constructorAccessSemantics, selector);
   }
 }
 
 abstract class DeclStructure<R, A> {
   final FunctionElement element;
 
   DeclStructure(this.element);
 
@@ skipping 290 matching lines @@
       return internalError(node, "Unexpected variable $element.");
     }
     if (element.isConst) {
       ConstantExpression constant = elements.getConstant(element.initializer);
       return new ConstantVariableStructure(kind, node, element, constant);
     } else {
       return new NonConstantVariableStructure(kind, node, element);
     }
   }
 }