Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136913006: dart2js: remove JS_OBJECT_CLASS_NAME and JS_NULL_CLASS_NAME from foreign (Closed)

Created:
5 years, 7 months ago by floitsch
Modified:
5 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, karlklose
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: remove JS_OBJECT_CLASS_NAME and JS_NULL_CLASS_NAME from foreign Instead of comparing the constructor's class name to the one of the Dart object class (or Null class), provide a builtin that returns whether a type is _the_ object or null type. This CL also starts the convention that internal types should have "rti" in their name. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/de495c6b200227ad491ea449978732d536e2cf2d

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Fix another typo. #

Patch Set 4 : More fixes #

Total comments: 6

Patch Set 5 : Remove empty lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -50 lines) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 2 3 4 2 chunks +18 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 2 chunks +18 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/foreign_helper.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 3 4 3 chunks +25 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_rti.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 2 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 7 months ago (2015-05-14 05:51:00 UTC) #2
sra1
lgtm https://codereview.chromium.org/1136913006/diff/60001/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart (right): https://codereview.chromium.org/1136913006/diff/60001/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart#newcode169 pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart:169: Remove these blank lines. (They are not in ...
5 years, 7 months ago (2015-05-14 19:12:59 UTC) #3
floitsch
https://codereview.chromium.org/1136913006/diff/60001/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart (right): https://codereview.chromium.org/1136913006/diff/60001/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart#newcode169 pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart:169: On 2015/05/14 19:12:59, sra1 wrote: > Remove these blank ...
5 years, 7 months ago (2015-05-19 15:39:26 UTC) #4
floitsch
5 years, 7 months ago (2015-05-19 15:40:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
de495c6b200227ad491ea449978732d536e2cf2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698