dart2js: remove JS_OBJECT_CLASS_NAME and JS_NULL_CLASS_NAME from foreign

pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.emitter;
 
 import 'package:_internal/compiler/js_lib/shared/embedded_names.dart' show
     JsBuiltin,
     METADATA,
     TYPES;
@@ skipping 129 matching lines @@
         return js.js.expressionTemplateYielding(
             typeAccess(_compiler.objectClass));
 
       case JsBuiltin.classNameFromIsCheckProperty:
         int isPrefixLength = namer.operatorIsPrefix.length;
         return js.js.expressionTemplateFor('#.substring($isPrefixLength)');
 
       case JsBuiltin.isFunctionType:
         return _backend.rti.representationGenerator.templateForIsFunctionType;
 
-      case JsBuiltin.isFunctionTypeLiteral:
-        String functionClassName =
-            _backend.namer.runtimeTypeName(_compiler.functionClass);
-
-        return js.js.expressionTemplateFor(
-            '#.$typeNameProperty === "$functionClassName"');
-
       case JsBuiltin.typeName:
         return js.js.expressionTemplateFor("#.$typeNameProperty");
 
       case JsBuiltin.rawRuntimeType:
         return js.js.expressionTemplateFor("#.constructor");
 
       case JsBuiltin.createFunctionType:
         return _backend.rti.representationGenerator
             .templateForCreateFunctionType;
 
       case JsBuiltin.isSubtype:
         // TODO(floitsch): move this closer to where is-check properties are
         // built.
         String isPrefix = namer.operatorIsPrefix;
         return js.js.expressionTemplateFor("('$isPrefix' + #) in #.prototype");
 
+      case JsBuiltin.isFunctionTypeRti:
+        String functionClassName =
+            _backend.namer.runtimeTypeName(_compiler.functionClass);
+

[sra1, 2015/05/14 19:12:59]

Remove these blank lines.  (They are not in the other emitter.)

[floitsch, 2015/05/19 15:39:26]

Done.

+        return js.js.expressionTemplateFor(
+            '#.$typeNameProperty === "$functionClassName"');
+
+      case JsBuiltin.isNullTypeRti:
+        String nullClassName =
+            _backend.namer.runtimeTypeName(_compiler.nullClass);
+

[sra1, 2015/05/14 19:12:59]

here

[floitsch, 2015/05/19 15:39:26]

Done.

+        return js.js.expressionTemplateFor(
+            '#.$typeNameProperty === "$nullClassName"');
+
+      case JsBuiltin.isDartObjectTypeRti:
+        String dartObjectClassName =
+            _backend.namer.runtimeTypeName(_compiler.objectClass);
+

[sra1, 2015/05/14 19:12:59]

here

[floitsch, 2015/05/19 15:39:26]

Done.

+        return js.js.expressionTemplateFor(
+            '#.$typeNameProperty === "$dartObjectClassName"');
+
       case JsBuiltin.getMetadata:
         return _emitter.templateForReadMetadata;
 
       case JsBuiltin.getType:
         return _emitter.templateForReadType;
 
       default:
         _compiler.internalError(NO_LOCATION_SPANNABLE,
                                 "Unhandled Builtin: $builtin");
         return null;
     }
   }
 
   @override
   void invalidateCaches() {
   }
 }