Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_rti.dart

Issue 1136913006: dart2js: remove JS_OBJECT_CLASS_NAME and JS_NULL_CLASS_NAME from foreign (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove empty lines. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/js_lib/js_rti.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_rti.dart b/sdk/lib/_internal/compiler/js_lib/js_rti.dart
index ec6ae53b14aa8f5210d2eb1fd1c34736bd4a0266..98394d43facd6213474476f1c62afddba7be2f1c 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_rti.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_rti.dart
@@ -364,8 +364,7 @@ computeSignature(var signature, var context, var contextName) {
*/
bool isSupertypeOfNull(var type) {
// `null` means `dynamic`.
- return type == null || getDartTypeName(type) == JS_OBJECT_CLASS_NAME()
- || getDartTypeName(type) == JS_NULL_CLASS_NAME();
+ return type == null || isDartObjectTypeRti(type) || isNullTypeRti(type);
}
/**
@@ -444,7 +443,7 @@ bool isSubtype(var s, var t) {
}
// Check function types against the Function class.
if (isDartFunctionType(s)) {
- return isDartFunctionTypeLiteral(t);
+ return isDartFunctionTypeRti(t);
}
// Get the object describing the class and check for the subtyping flag
« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/js_helper.dart ('k') | sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698