Issue 11361093: Address Peter's comments in https://codereview.chromium.org/11361059, and fix a host-checked mode b…

Issue 11361093: Address Peter's comments in https://codereview.chromium.org/11361059, and fix a host-checked mode b… (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address Peter's comments in https://codereview.chromium.org/11361059, and fix a host-checked mode bug. Committed: https://code.google.com/p/dart/source/detail?r=14522

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	tests/language/checked_null_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/typed_selector2_test.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right): https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart#newcode428 sdk/lib/_internal/compiler/implementation/universe/universe.dart:428: // user-defined member. member -> members. https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/implementation/universe/universe.dart#newcode438 sdk/lib/_internal/compiler/implementation/universe/universe.dart:438: ...

8 years, 1 month ago (2012-11-05 11:23:01 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-05 11:40:01 UTC) #3

Thanks Peter.

https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:428: //
user-defined member.
On 2012/11/05 11:23:01, ahe wrote:
> member -> members.

Done.

https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:428: //
user-defined member.
On 2012/11/05 11:23:01, ahe wrote:
> member -> members.

Done.

https://codereview.chromium.org/11361093/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:438: if
(self.isSubclassOf(other)) {
On 2012/11/05 11:23:01, ahe wrote:
> Should this be checking subtype relation instead?

No, this is checking if [element] (which is defined in [other]) is inherited by
[self]. If [self] just implements [other], it doesn't inherit the implementation
of [element].

I added the comment.

https://codereview.chromium.org/11361093/diff/1/tests/language/typed_selector...
File tests/language/typed_selector2_test.dart (right):

https://codereview.chromium.org/11361093/diff/1/tests/language/typed_selector...
tests/language/typed_selector2_test.dart:4: 
On 2012/11/05 11:23:01, ahe wrote:
> What does this test do? (comment, please)

Done.

Expand Messages | Collapse Messages