Address Peter's comments in https://codereview.chromium.org/11361059, and fix a host-checked mode b…

sdk/lib/_internal/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../closure.dart';
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../runtime_types.dart';
@@ skipping 404 matching lines @@
     // A closure can be called through any typed selector:
     // class A {
     //   get foo => () => 42;
     //   bar() => foo(); // The call to 'foo' is a typed selector.
     // }
     ClassElement other = element.getEnclosingClass();
     if (identical(other.superclass, compiler.closureClass)) {
       return appliesUntyped(element, compiler);
     }
 
-    ClassElement self = receiverType.element;
+    Element self = receiverType.element;
+    if (self.isTypedef()) {
+      // A typedef is a function type that doesn't have any
+      // user-defined member.

[ahe, 2012/11/05 11:23:01]

member -> members.

[ngeoffray, 2012/11/05 11:40:01]

Done.

[ngeoffray, 2012/11/05 11:40:01]

Done.

+      return false;
+    }
 
     if (other.implementsInterface(self)
         || other.isSubclassOf(self)
         || compiler.world.hasAnySubclassThatImplements(other, receiverType)) {
       return appliesUntyped(element, compiler);
     }
 
-    if (!self.isTypedef() && !self.isInterface() && self.isSubclassOf(other)) {
+    if (self.isSubclassOf(other)) {

[ahe, 2012/11/05 11:23:01]

Should this be checking subtype relation instead?

[ngeoffray, 2012/11/05 11:40:01]

No, this is checking if [element] (which is defined in [other]) is inherited by
[self]. If [self] just implements [other], it doesn't inherit the implementation
of [element].

I added the comment.

       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 }