Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 11360121: When building standalone Dart executable, put implementation of dart:io natives in a separate libra… (Closed)

Created:
8 years, 1 month ago by Bill Hesse
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

When building standalone Dart executable, put implementation of dart:io natives in a separate library. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14679

Patch Set 1 #

Patch Set 2 : Fix comments. #

Patch Set 3 : Fix grammar. #

Total comments: 5

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -65 lines) Patch
M runtime/bin/bin.gypi View 1 2 3 6 chunks +36 lines, -1 line 0 comments Download
M runtime/bin/builtin.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/builtin.cc View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
A + runtime/bin/builtin_gen_snapshot.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/builtin_impl_sources.gypi View 1 2 3 3 chunks +3 lines, -29 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 1 2 3 4 chunks +7 lines, -23 lines 0 comments Download
M runtime/bin/builtin_nolib.cc View 2 chunks +10 lines, -1 line 0 comments Download
A runtime/bin/io_impl_sources.gypi View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A + runtime/bin/io_natives.h View 1 chunk +6 lines, -9 lines 0 comments Download
A runtime/bin/io_natives.cc View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
This refactoring of the build makes it possible to add libraries to the implementation of ...
8 years, 1 month ago (2012-11-07 15:25:03 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-11-08 09:32:26 UTC) #2
LGTM with comments.

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/bin.gypi#newcod...
runtime/bin/bin.gypi:309: 'dependencies': [
Can you leave this out since it is empty?

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/bin.gypi#newcod...
runtime/bin/bin.gypi:459: 'libdart_io',
Move this up to after libdart_builtin and leave generate_snapshot_file as the
last one?

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/bin.gypi#newcod...
runtime/bin/bin.gypi:545: 'builtin_fulllib.cc',
Would it be better to do the naming the other way around.

builtin.cc remains the one that has everything.
builtin_nolib.cc remains the one that has everything but no source code.
builtin_gen_snapshot.cc is the new one which has only the stuff needed for
snapshot generation.

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/builtin.cc#newc...
runtime/bin/builtin.cc:56: // This is for use in the snapshot generator, which
must not link with
Instead of focusing this comment on the problem caused by the dependency, maybe
write that the snapshot generator does not need most of the dart:io C++ code and
should be indenpendent of it.

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/builtin_natives.cc
File runtime/bin/builtin_natives.cc (right):

http://codereview.chromium.org/11360121/diff/4001/runtime/bin/builtin_natives...
runtime/bin/builtin_natives.cc:21: V(Crypto_GetRandomBytes, 1)                  
                               \
I think these first two can be moved too?

Powered by Google App Engine
This is Rietveld 408576698