Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: runtime/bin/builtin_gen_snapshot.cc

Issue 11360121: When building standalone Dart executable, put implementation of dart:io natives in a separate libra… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/builtin_impl_sources.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <stdio.h> 5 #include <stdio.h>
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "bin/builtin.h" 9 #include "bin/builtin.h"
10 #include "bin/dartutils.h" 10 #include "bin/dartutils.h"
(...skipping 12 matching lines...) Expand all
23 23
24 24
25 Dart_Handle Builtin::Source(BuiltinLibraryId id) { 25 Dart_Handle Builtin::Source(BuiltinLibraryId id) {
26 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 26 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
27 kInvalidLibrary); 27 kInvalidLibrary);
28 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary); 28 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
29 return DartUtils::NewString(builtin_libraries_[id].source_); 29 return DartUtils::NewString(builtin_libraries_[id].source_);
30 } 30 }
31 31
32 32
33 Dart_NativeFunction Builtin::NativeLookup(Dart_Handle name,
34 int argument_count) {
35 UNREACHABLE();
36 return NULL;
37 }
38
39
33 void Builtin::SetNativeResolver(BuiltinLibraryId id) { 40 void Builtin::SetNativeResolver(BuiltinLibraryId id) {
34 UNREACHABLE(); 41 UNREACHABLE();
35 } 42 }
36 43
37 44
38 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) { 45 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) {
39 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 46 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
40 kInvalidLibrary); 47 kInvalidLibrary);
41 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary); 48 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
42 Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_); 49 Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_);
43 Dart_Handle library = Dart_LookupLibrary(url); 50 Dart_Handle library = Dart_LookupLibrary(url);
44 if (Dart_IsError(library)) { 51 if (Dart_IsError(library)) {
45 library = Dart_LoadLibrary(url, Source(id)); 52 library = Dart_LoadLibrary(url, Source(id));
46 if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) { 53 if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) {
47 // Setup the native resolver for built in library functions. 54 // Setup the native resolver for built in library functions.
48 DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup)); 55 // Looks up native functions only in libdart_builtin, not libdart_io.
56 // This is for use in the snapshot generator, which should be
57 // independent of most of the dart:io C++ code.
58 DART_CHECK_VALID(Dart_SetNativeResolver(library, BuiltinNativeLookup));
49 } 59 }
50 if (builtin_libraries_[id].patch_url_ != NULL) { 60 if (builtin_libraries_[id].patch_url_ != NULL) {
51 ASSERT(builtin_libraries_[id].patch_source_ != NULL); 61 ASSERT(builtin_libraries_[id].patch_source_ != NULL);
52 Dart_Handle patch_url = 62 Dart_Handle patch_url =
53 DartUtils::NewString(builtin_libraries_[id].patch_url_); 63 DartUtils::NewString(builtin_libraries_[id].patch_url_);
54 Dart_Handle patch_source = 64 Dart_Handle patch_source =
55 DartUtils::NewString(builtin_libraries_[id].patch_source_); 65 DartUtils::NewString(builtin_libraries_[id].patch_source_);
56 DART_CHECK_VALID(Dart_LoadPatch(library, patch_url, patch_source)); 66 DART_CHECK_VALID(Dart_LoadPatch(library, patch_url, patch_source));
57 } 67 }
58 } 68 }
59 DART_CHECK_VALID(library); 69 DART_CHECK_VALID(library);
60 return library; 70 return library;
61 } 71 }
OLDNEW
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/builtin_impl_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698