Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: runtime/bin/builtin_nolib.cc

Issue 11360121: When building standalone Dart executable, put implementation of dart:io natives in a separate libra… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/io_impl_sources.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <stdio.h> 5 #include <stdio.h>
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "bin/builtin.h" 9 #include "bin/builtin.h"
10 #include "bin/dartutils.h" 10 #include "bin/dartutils.h"
11 11 #include "bin/io_natives.h"
12 12
13 Builtin::builtin_lib_props Builtin::builtin_libraries_[] = { 13 Builtin::builtin_lib_props Builtin::builtin_libraries_[] = {
14 /* { url_, source_, patch_url_, patch_source_, has_natives_ } */ 14 /* { url_, source_, patch_url_, patch_source_, has_natives_ } */
15 { DartUtils::kBuiltinLibURL, NULL, NULL, NULL, true }, 15 { DartUtils::kBuiltinLibURL, NULL, NULL, NULL, true },
16 { DartUtils::kJsonLibURL, NULL, NULL, NULL, false }, 16 { DartUtils::kJsonLibURL, NULL, NULL, NULL, false },
17 { DartUtils::kUriLibURL, NULL, NULL, NULL, false }, 17 { DartUtils::kUriLibURL, NULL, NULL, NULL, false },
18 { DartUtils::kCryptoLibURL, NULL, NULL, NULL, false }, 18 { DartUtils::kCryptoLibURL, NULL, NULL, NULL, false },
19 { DartUtils::kIOLibURL, NULL, NULL, NULL, true }, 19 { DartUtils::kIOLibURL, NULL, NULL, NULL, true },
20 { DartUtils::kUtfLibURL, NULL, NULL, NULL, false } 20 { DartUtils::kUtfLibURL, NULL, NULL, NULL, false }
21 }; 21 };
22 22
23 23
24 Dart_Handle Builtin::Source(BuiltinLibraryId id) { 24 Dart_Handle Builtin::Source(BuiltinLibraryId id) {
25 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 25 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
26 kInvalidLibrary); 26 kInvalidLibrary);
27 return Dart_NewApiError("Unreachable code in Builtin::Source (%d).", id); 27 return Dart_NewApiError("Unreachable code in Builtin::Source (%d).", id);
28 } 28 }
29 29
30 /**
31 * Looks up native functions in both libdart_builtin and libdart_io.
32 */
33 Dart_NativeFunction Builtin::NativeLookup(Dart_Handle name,
34 int argument_count) {
35 Dart_NativeFunction result = BuiltinNativeLookup(name, argument_count);
36 if (result != NULL) return result;
37 return IONativeLookup(name, argument_count);
38 }
30 39
31 void Builtin::SetNativeResolver(BuiltinLibraryId id) { 40 void Builtin::SetNativeResolver(BuiltinLibraryId id) {
32 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 41 ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
33 kInvalidLibrary); 42 kInvalidLibrary);
34 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary); 43 ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
35 if (builtin_libraries_[id].has_natives_) { 44 if (builtin_libraries_[id].has_natives_) {
36 Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_); 45 Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_);
37 Dart_Handle library = Dart_LookupLibrary(url); 46 Dart_Handle library = Dart_LookupLibrary(url);
38 ASSERT(!Dart_IsError(library)); 47 ASSERT(!Dart_IsError(library));
39 // Setup the native resolver for built in library functions. 48 // Setup the native resolver for built in library functions.
(...skipping 12 matching lines...) Expand all
52 ASSERT(id > kUtfLibrary); 61 ASSERT(id > kUtfLibrary);
53 library = Dart_LoadLibrary(url, Source(id)); 62 library = Dart_LoadLibrary(url, Source(id));
54 if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) { 63 if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) {
55 // Setup the native resolver for built in library functions. 64 // Setup the native resolver for built in library functions.
56 DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup)); 65 DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup));
57 } 66 }
58 } 67 }
59 DART_CHECK_VALID(library); 68 DART_CHECK_VALID(library);
60 return library; 69 return library;
61 } 70 }
OLDNEW
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/io_impl_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698