Issue 11348281: Put back manual inlining of List.add, List.removeLast, String.split and String.concat.

Issue 11348281: Put back manual inlining of List.add, List.removeLast, String.split and String.concat. (Closed)

Created:
8 years ago by ngeoffray

Modified:
8 years ago

Reviewers:
ahe, karlklose, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Put back manual inlining of List.add, List.removeLast, String.split and String.concat. Committed: https://code.google.com/p/dart/source/detail?r=15500

Patch Set 2 : #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -16 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	2 chunks	+12 lines, -0 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+13 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1	7 chunks	+49 lines, -13 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11348281/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11348281/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1559 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1559: world.registerInstantiatedClass(compiler.listClass); Add a comment that explains why you ...

8 years ago (2012-11-29 08:10:48 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/11348281/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11348281/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1559 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1559: world.registerInstantiatedClass(compiler.listClass); On 2012/11/29 08:10:48, kasperl wrote: > ...

8 years ago (2012-11-29 08:46:51 UTC) #3

ahe

8 years ago (2012-11-30 08:11:42 UTC) #4

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/11348281/diff/3002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/11348281/diff/3002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:780:
jsArrayClass.lookupLocalMember(const SourceString('removeLast'));
I think you need to check that you can actually find these members.  That is,
use a helper method that validates the result.

https://codereview.chromium.org/11348281/diff/3002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/11348281/diff/3002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:42: new
SsaConstantFolder(constantSystem, backend, work, types),
Add a comment explaining why you call the constant folder again?

https://codereview.chromium.org/11348281/diff/3002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:210: if (node is
!HInvokeDynamicMethod) return;
I don't understand this line.

https://codereview.chromium.org/11348281/diff/3002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:236: &&
selector.argumentCount == 0) {
Why isn't this selector.applies(backend.jsArrayRemoveLast)?

Expand Messages | Collapse Messages