Put back manual inlining of List.add, List.removeLast, String.split and String.concat.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 1525 matching lines @@
     use(node.receiver);
     List<js.Expression> arguments = <js.Expression>[pop()];
     push(new js.Call(interceptor, arguments), node);
   }
 
   visitInvokeDynamicMethod(HInvokeDynamicMethod node) {
     use(node.receiver);
     js.Expression object = pop();
     SourceString name = node.selector.name;
     String methodName;
-    List<js.Expression> arguments;
+    List<js.Expression> arguments = visitArguments(node.inputs);
     Element target = node.element;
 
     // Avoid adding the generative constructor name to the list of
     // seen selectors.
     if (target != null && target.isGenerativeConstructorBody()) {
       methodName = name.slowToString();
-      arguments = visitArguments(node.inputs);
+    } else if (target == backend.jsArrayAdd) {
+      methodName = 'push';
+    } else if (target == backend.jsArrayRemoveLast) {
+      methodName = 'pop';
+    } else if (target == backend.jsStringSplit) {
+      methodName = 'split';
+      world.registerInstantiatedClass(compiler.listClass);

[kasperl, 2012/11/29 08:10:48]

Add a comment that explains why you need to instantiate the list class here. I
guess it's because split returns a new list.

[ngeoffray, 2012/11/29 08:46:51]

Done.

+    } else if (target == backend.jsStringConcat) {
+      push(new js.Binary('+', object, arguments[0]), node);
+      return;
     } else {
       methodName = backend.namer.instanceMethodInvocationName(
           node.selector.library, name, node.selector);
-      arguments = visitArguments(node.inputs);
       bool inLoop = node.block.enclosingLoopHeader != null;
 
       Selector selector = getOptimizedSelectorFor(node, node.selector);
       if (node.isInterceptorCall) {
         backend.addInterceptedSelector(selector);
       }
       // Register this invocation to collect the types used at all call sites.
       backend.registerDynamicInvocation(node, selector, types);
 
       // If we don't know what we're calling or if we are calling a getter,
@@ skipping 1452 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }