Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 11348281: Put back manual inlining of List.add, List.removeLast, String.split and String.concat. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (revision 15496)
+++ sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (working copy)
@@ -634,6 +634,10 @@
ClassElement objectInterceptorClass;
Element jsArrayLength;
Element jsStringLength;
+ Element jsArrayRemoveLast;
+ Element jsArrayAdd;
+ Element jsStringSplit;
+ Element jsStringConcat;
Element getInterceptorMethod;
bool _interceptorsAreInitialized = false;
@@ -772,10 +776,18 @@
jsArrayClass.ensureResolved(compiler);
jsArrayLength =
jsArrayClass.lookupLocalMember(const SourceString('length'));
+ jsArrayRemoveLast =
+ jsArrayClass.lookupLocalMember(const SourceString('removeLast'));
ahe 2012/11/30 08:11:42 I think you need to check that you can actually fi
+ jsArrayAdd =
+ jsArrayClass.lookupLocalMember(const SourceString('add'));
jsStringClass.ensureResolved(compiler);
jsStringLength =
jsStringClass.lookupLocalMember(const SourceString('length'));
+ jsStringSplit =
+ jsStringClass.lookupLocalMember(const SourceString('split'));
+ jsStringConcat =
+ jsStringClass.lookupLocalMember(const SourceString('concat'));
for (ClassElement cls in classes) {
if (cls != null) interceptedClasses[cls] = null;

Powered by Google App Engine
This is Rietveld 408576698