Issue 11348259: Canonicalize all integer constants taht we create by parsing a string.

Issue 11348259: Canonicalize all integer constants taht we create by parsing a string. (Closed)

Created:
8 years ago by siva

Modified:
8 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Canonicalize all integer constants that we create by parsing a string. Committed: https://code.google.com/p/dart/source/detail?r=15427

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -13 lines)			Patch
M	runtime/vm/object.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	5 chunks	+53 lines, -3 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1	3 chunks	+11 lines, -9 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comments https://codereview.chromium.org/11348259/diff/1/runtime/lib/double.cc File runtime/lib/double.cc (right): https://codereview.chromium.org/11348259/diff/1/runtime/lib/double.cc#newcode224 runtime/lib/double.cc:224: return Double::NewCanonical(double_value); Do not canonicalize om ...

8 years ago (2012-11-27 23:32:07 UTC) #2

siva

8 years ago (2012-11-28 00:22:56 UTC) #3

https://codereview.chromium.org/11348259/diff/1/runtime/lib/double.cc
File runtime/lib/double.cc (right):

https://codereview.chromium.org/11348259/diff/1/runtime/lib/double.cc#newcode224
runtime/lib/double.cc:224: return Double::NewCanonical(double_value);
On 2012/11/27 23:32:07, srdjan wrote:
> Do not canonicalize om this native, as it is called on program data not on
> program.

Done.

https://codereview.chromium.org/11348259/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/11348259/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:202: return Integer::NewCanonical(temp);
On 2012/11/27 23:32:07, srdjan wrote:
> ditto.

Done.

https://codereview.chromium.org/11348259/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/11348259/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:1354: return Api::NewHandle(isolate,
Integer::NewCanonical(str_obj));
On 2012/11/27 23:32:07, srdjan wrote:
> ditto

Done.

Expand Messages | Collapse Messages