Canonicalize all integer constants taht we create by parsing a string.

runtime/lib/double.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <math.h>
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/double_conversion.h"
@@ skipping 203 matching lines @@
                               Token::kDOUBLE,
                               &is_positive,
                               &number_string)) {
     const char* cstr = number_string->ToCString();
     char* p_end = NULL;
     double double_value = strtod(cstr, &p_end);
     ASSERT(p_end != cstr);
     if (!is_positive) {
       double_value = -double_value;
     }
-    return Double::New(double_value);
+    return Double::NewCanonical(double_value);

[srdjan, 2012/11/27 23:32:07]

Do not canonicalize om this native, as it is called on program data not on
program.

[siva, 2012/11/28 00:22:56]

Done.

   }
 
   if (Scanner::IsValidLiteral(tokens,
                               Token::kINTEGER,
                               &is_positive,
                               &number_string)) {
-    Integer& res = Integer::Handle(Integer::New(*number_string));
+    Integer& res = Integer::Handle(Integer::NewCanonical(*number_string));
     if (is_positive) {
-      return Double::New(res.AsDoubleValue());
+      return Double::NewCanonical(res.AsDoubleValue());
     }
-    return Double::New(-res.AsDoubleValue());
+    return Double::NewCanonical(-res.AsDoubleValue());
   }
 
   // Infinity and nan.
   if (Scanner::IsValidLiteral(tokens,
                               Token::kIDENT,
                               &is_positive,
                               &number_string)) {
     if (number_string->Equals("NaN")) {
-      return Double::New(NAN);
+      return Double::NewCanonical(NAN);
     }
     if (number_string->Equals("Infinity")) {
       if (is_positive) {
-        return Double::New(INFINITY);
+        return Double::NewCanonical(INFINITY);
       }
-      return Double::New(-INFINITY);
+      return Double::NewCanonical(-INFINITY);
     }
   }
 
   GrowableArray<const Object*> args;
   args.Add(&value);
   Exceptions::ThrowByType(Exceptions::kFormat, args);
   return Object::null();
 }
 
 
@@ skipping 68 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Double_getIsNegative, 1) {
   const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
   // Include negative zero, infinity.
   return Bool::Get(signbit(arg.value()) && !isnan(arg.value()));
 }
 
 // Add here only functions using/referring to old-style casts.
 
 }  // namespace dart