Canonicalize all integer constants taht we create by parsing a string.

runtime/lib/integers.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
@@ skipping 177 matching lines @@
   const String& dummy_key = String::Handle(Symbols::Empty());
   Scanner scanner(value, dummy_key);
   const Scanner::GrowableTokenStream& tokens = scanner.GetStream();
   String* int_string;
   bool is_positive;
   if (Scanner::IsValidLiteral(tokens,
                              Token::kINTEGER,
                              &is_positive,
                              &int_string)) {
     if (is_positive) {
-      return Integer::New(*int_string);
+      return Integer::NewCanonical(*int_string);
     }
     String& temp = String::Handle();
     temp = String::Concat(String::Handle(Symbols::New("-")), *int_string);
-    return Integer::New(temp);
+    return Integer::NewCanonical(temp);

[srdjan, 2012/11/27 23:32:07]

ditto.

[siva, 2012/11/28 00:22:56]

Done.

   }
 
   GrowableArray<const Object*> args;
   args.Add(&value);
   Exceptions::ThrowByType(Exceptions::kFormat, args);
   return Object::null();
 }
 
 
 static RawInteger* ShiftOperationHelper(Token::Kind kind,
@@ skipping 95 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Bigint_bitNegate, 1) {
   const Bigint& value = Bigint::CheckedHandle(arguments->NativeArgAt(0));
   const Bigint& result = Bigint::Handle(BigintOperations::BitNot(value));
   ASSERT(CheckInteger(value));
   ASSERT(CheckInteger(result));
   return result.AsValidInteger();
 }
 
 }  // namespace dart