Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133733005: Use words please. (Closed)

Created:
5 years, 7 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use words please. eval -> evaluate isolate.evaluate(object, expression) -> object.evaluate(expression) R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45823

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix checked mode #

Patch Set 4 : also rename service rpc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -96 lines) Patch
M runtime/observatory/lib/dominator_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_view.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 7 chunks +18 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/allocations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/caching_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/call_site_data_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/debugger_inspect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_activation_test.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/get_instances_rpc_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/get_retained_size_rpc_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_retaining_path_rpc_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/graph_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/inbound_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/mirror_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/source_location_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/string_escaping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/weak_properties_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rmacnak
5 years, 7 months ago (2015-05-15 18:23:03 UTC) #2
Cutch
lgtm
5 years, 7 months ago (2015-05-15 19:54:32 UTC) #3
Cutch
lgtm lgtm
5 years, 7 months ago (2015-05-15 19:54:32 UTC) #4
turnidge
Please change the rpc name in the service protocol as well. If it's worth changing ...
5 years, 7 months ago (2015-05-15 20:03:36 UTC) #5
rmacnak
On 2015/05/15 20:03:36, turnidge wrote: > Please change the rpc name in the service protocol ...
5 years, 7 months ago (2015-05-15 20:28:19 UTC) #6
rmacnak
5 years, 7 months ago (2015-05-15 20:29:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 45823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698