runtime/observatory/lib/src/elements/isolate_view.dart - Issue 1133733005: Use words please.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 1133733005: Use words please. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: also rename service rpc Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/isolate_view.dart

diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart

index db65066face224a5906e25a5357a0ae77c0f22cc..766f2874d781ad7ec2c96f6a6ff442868c05d971 100644

--- a/runtime/observatory/lib/src/elements/isolate_view.dart

+++ b/runtime/observatory/lib/src/elements/isolate_view.dart

@@ -83,8 +83,8 @@ class IsolateViewElement extends ObservatoryElement {

TagProfileChart tagProfileChart = new TagProfileChart();

IsolateViewElement.created() : super.created();

- Future<ServiceObject> eval(String expression) {

- return isolate.eval(isolate.rootLib, expression);

+ Future<ServiceObject> evaluate(String expression) {

+ return isolate.rootLibrary.evaluate(expression);

}

void _updateTagProfile() {