runtime/observatory/tests/service/get_retained_size_rpc_test.dart - Issue 1133733005: Use words please.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_retained_size_rpc_test.dart

Issue 1133733005: Use words please. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: also rename service rpc Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/get_retained_size_rpc_test.dart

diff --git a/runtime/observatory/tests/service/get_retained_size_rpc_test.dart b/runtime/observatory/tests/service/get_retained_size_rpc_test.dart

index e71acb67403fb7769b673fdb1401eecbec646dc1..9311ccf4af0aa0ceb5eb933c02d61bcadbd3021c 100644

--- a/runtime/observatory/tests/service/get_retained_size_rpc_test.dart

+++ b/runtime/observatory/tests/service/get_retained_size_rpc_test.dart

@@ -20,10 +20,10 @@ eval(Isolate isolate, String expression) async {

// Silence analyzer.

new _TestClass(null, null);

Map params = {

- 'targetId': isolate.rootLib.id,

+ 'targetId': isolate.rootLibrary.id,

'expression': expression,

};

- return await isolate.invokeRpcNoUpgrade('eval', params);

+ return await isolate.invokeRpcNoUpgrade('evaluate', params);

}

var tests = [