Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131423002: Clean up many generated constructors (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up many generated constructors R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45676

Patch Set 1 #

Patch Set 2 : Comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+719 lines, -534 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/generated/util.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 45 chunks +176 lines, -82 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 6 chunks +13 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 9 chunks +47 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 9 chunks +34 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 6 chunks +41 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 53 chunks +81 lines, -65 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 4 chunks +21 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 5 chunks +20 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 17 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 10 chunks +16 lines, -23 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 22 chunks +41 lines, -41 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 35 chunks +55 lines, -56 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 30 chunks +50 lines, -51 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 19 chunks +30 lines, -39 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-09 16:57:47 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-09 17:09:11 UTC) #3
Brian Wilkerson
5 years, 7 months ago (2015-05-09 19:07:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 45676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698