pkg/analysis_server/lib/src/services/refactoring/extract_local.dart - Issue 1131423002: Clean up many generated constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

Issue 1131423002: Clean up many generated constructors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comment change Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/extract_method.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

index 8d7782c0db05499255a0057bceec6eb667153e3c..3acc98241340899527e2ad4d8941459931ee1c6c 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

@@ -319,7 +319,7 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl

List<AstNode> _findNodes(List<SourceRange> ranges) {

List<AstNode> nodes = <AstNode>[];

for (SourceRange range in ranges) {

- AstNode node = new NodeLocator.con1(range.offset).searchWithin(unit);

+ AstNode node = new NodeLocator(range.offset).searchWithin(unit);

nodes.add(node);

}

return nodes;

@@ -402,7 +402,7 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl

AstNode enclosingFunction;

{

AstNode selectionNode =

- new NodeLocator.con1(selectionOffset).searchWithin(unit);

+ new NodeLocator(selectionOffset).searchWithin(unit);

enclosingFunction = getEnclosingExecutableNode(selectionNode);

}

// visit function