Clean up many generated constructors

pkg/analyzer/lib/src/generated/error.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.error;
 
 import 'dart:collection';
 
 import 'ast.dart' show AstNode;
 import 'element.dart';
@@ skipping 71 matching lines @@
    */
   int _length = 0;
 
   /**
    * A flag indicating whether this error can be shown to be a non-issue because
    * of the result of type propagation.
    */
   bool isStaticOnly = false;
 
   /**
+   * Initialize a newly created analysis error. The error is associated with the
+   * given [source] and is located at the given [offset] with the given
+   * [length]. The error will have the given [errorCode] and the list of
+   * [arguments] will be used to complete the message.
+   */
+  AnalysisError(this.source, this.offset, int length, this.errorCode,
+      [List<Object> arguments]) {
+    this._length = length;
+    this._message = formatList(errorCode.message, arguments);
+    String correctionTemplate = errorCode.correction;
+    if (correctionTemplate != null) {
+      this._correction = formatList(correctionTemplate, arguments);
+    }
+  }
+
+  /**
    * Initialize a newly created analysis error for the specified [source]. The
    * error will have the given [errorCode] and the list of [arguments] will be
    * used to complete the message. The error has no location information.
    */
-  AnalysisError.con1(this.source, this.errorCode, [List<Object> arguments]) {
-    this._message = formatList(errorCode.message, arguments);
-  }
+  @deprecated // Use new AnalysisError(source, 0, 0, errorCode, arguments)
+  AnalysisError.con1(Source source, ErrorCode errorCode,
+      [List<Object> arguments])
+      : this(source, 0, 0, errorCode, arguments);
 
   /**
    * Initialize a newly created analysis error for the specified [source] at the
    * given [offset] with the given [length]. The error will have the given
    * [errorCode] and the list of [arguments] will be used to complete the
    * message.
    */
-  AnalysisError.con2(this.source, this.offset, int length, this.errorCode,
-      [List<Object> arguments]) {
-    this._length = length;
-    this._message = formatList(errorCode.message, arguments);
-    String correctionTemplate = errorCode.correction;
-    if (correctionTemplate != null) {
-      this._correction = formatList(correctionTemplate, arguments);
-    }
-  }
+  @deprecated // Use new AnalysisError(source, offset, length, errorCode, arguments)
+  AnalysisError.con2(Source source, int offset, int length, ErrorCode errorCode,
+      [List<Object> arguments])
+      : this(source, offset, length, errorCode, arguments);
 
   /**
    * Return the template used to create the correction to be displayed for this
    * error, or `null` if there is no correction information for this error. The
    * correction should indicate how the user can fix the error.
    */
   String get correction => _correction;
 
   @override
   int get hashCode {
@@ skipping 112 matching lines @@
  * An [AnalysisError] that can have arbitrary properties associated with it.
  */
 class AnalysisErrorWithProperties extends AnalysisError {
   /**
    * The properties associated with this error.
    */
   HashMap<ErrorProperty, Object> _propertyMap =
       new HashMap<ErrorProperty, Object>();
 
   /**
+   * Initialize a newly created analysis error. The error is associated with the
+   * given [source] and is located at the given [offset] with the given
+   * [length]. The error will have the given [errorCode] and the list of
+   * [arguments] will be used to complete the message.
+   */
+  AnalysisErrorWithProperties(
+      Source source, int offset, int length, ErrorCode errorCode,
+      [List<Object> arguments])
+      : super(source, offset, length, errorCode, arguments);
+
+  /**
    * Initialize a newly created analysis error for the specified [source]. The
    * error will have the given [errorCode] and the list of [arguments] will be
    * used to complete the message. The error has no location information.
    */
+  @deprecated // Use new AnalysisErrorWithProperties(source, 0, 0, errorCode, arguments)
   AnalysisErrorWithProperties.con1(Source source, ErrorCode errorCode,
       [List<Object> arguments])
-      : super.con1(source, errorCode, arguments);
+      : this(source, 0, 0, errorCode, arguments);
 
   /**
    * Initialize a newly created analysis error for the specified [source] at the
    * given [offset] with the given [length]. The error will have the given
    * [errorCode] and the list of [arguments] will be used to complete the
    * message.
    */
+  @deprecated // Use new AnalysisErrorWithProperties(source, offset, length, errorCode, arguments)
   AnalysisErrorWithProperties.con2(
       Source source, int offset, int length, ErrorCode errorCode,
       [List<Object> arguments])
-      : super.con2(source, offset, length, errorCode, arguments);
+      : this(source, offset, length, errorCode, arguments);
 
   @override
   Object getProperty(ErrorProperty property) => _propertyMap[property];
 
   /**
    * Set the value of the given [property] to the given [value]. Using a value
    * of `null` will effectively remove the property from this error.
    */
   void setProperty(ErrorProperty property, Object value) {
     _propertyMap[property] = value;
@@ skipping 2189 matching lines @@
   void set source(Source source) {
     this._source = source == null ? _defaultSource : source;
   }
 
   /**
    * Creates an error with properties with the given [errorCode] and
    * [arguments]. The [node] is used to compute the location of the error.
    */
   AnalysisErrorWithProperties newErrorWithProperties(
           ErrorCode errorCode, AstNode node, List<Object> arguments) =>
-      new AnalysisErrorWithProperties.con2(
+      new AnalysisErrorWithProperties(
           _source, node.offset, node.length, errorCode, arguments);
 
   /**
    * Report the given [error].
    */
   void reportError(AnalysisError error) {
     _errorListener.onError(error);
   }
 
   /**
@@ skipping 27 matching lines @@
     reportErrorForOffset(errorCode, node.offset, node.length, arguments);
   }
 
   /**
    * Report an error with the given [errorCode] and [arguments]. The location of
    * the error is specified by the given [offset] and [length].
    */
   void reportErrorForOffset(ErrorCode errorCode, int offset, int length,
       [List<Object> arguments]) {
     _errorListener.onError(
-        new AnalysisError.con2(_source, offset, length, errorCode, arguments));
+        new AnalysisError(_source, offset, length, errorCode, arguments));
   }
 
   /**
    * Report an error with the given [errorCode] and [arguments]. The [token] is
    * used to compute the location of the error.
    */
   void reportErrorForToken(ErrorCode errorCode, Token token,
       [List<Object> arguments]) {
     reportErrorForOffset(errorCode, token.offset, token.length, arguments);
   }
@@ skipping 2372 matching lines @@
    * Initialize a newly created error code to have the given [name].
    */
   const TodoCode(String name) : super(name, "{0}");
 
   @override
   ErrorSeverity get errorSeverity => ErrorSeverity.INFO;
 
   @override
   ErrorType get type => ErrorType.TODO;
 }