Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 11314019: Using 'interface' and 'abstract' for methods should produce error (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Using 'interface' and 'abstract' for methods should produce error R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14165

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -1809 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 5 chunks +17 lines, -20 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java View 4 chunks +2 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +15 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java View 1 chunk +0 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 5 chunks +0 lines, -144 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 2 chunks +0 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 3 chunks +6 lines, -39 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.intfchange.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.newmethod.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart View 1 chunk +12 lines, -12 lines 3 comments Download
M compiler/javatests/com/google/dart/compiler/parser/ErrorMessageLocationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/MethodSignatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 6 chunks +22 lines, -11 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java View 6 chunks +9 lines, -42 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/TryCatch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java View 7 chunks +7 lines, -7 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java View 6 chunks +2 lines, -42 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/resolver/RawTypesNegativeTest.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java View 7 chunks +5 lines, -508 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 22 chunks +23 lines, -420 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 18 chunks +18 lines, -111 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 13 chunks +9 lines, -137 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/class_with_methods.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/class_with_supertypes.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/class_with_type_parameter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/covariant_class.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/generic_class_with_supertypes.dart View 1 chunk +1 line, -1 line 0 comments Download
D compiler/javatests/com/google/dart/compiler/type/interfaces.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/search/SearchEngineTest.java View 1 chunk +0 lines, -64 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/currency.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/currency_exchange.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/money.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameTypeProcessorTest.java View 1 chunk +0 lines, -144 lines 0 comments Download
M pkg/dartdoc/lib/mirrors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dartdoc/lib/src/markdown/block_parser.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/dartdoc/lib/src/markdown/inline_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/intl/lib/src/intl_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/interfaces.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/unittest/matcher.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/dartcombat/player.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M samples/swarm/UIState.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/ui_lib/touch/Momentum.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/language/language.status View 5 chunks +86 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 1 month ago (2012-10-27 04:01:34 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/11314019/diff/1/compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart File compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart (right): https://codereview.chromium.org/11314019/diff/1/compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart#newcode114 compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart:114: //interface Foo extends D, E { It looks ...
8 years, 1 month ago (2012-10-27 15:13:25 UTC) #2
scheglov
8 years, 1 month ago (2012-10-27 18:08:47 UTC) #3
https://codereview.chromium.org/11314019/diff/1/compiler/javatests/com/google...
File compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart
(right):

https://codereview.chromium.org/11314019/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/parser/ClassesInterfaces.dart:114:
//interface Foo extends D, E {
On 2012/10/27 15:13:25, Brian Wilkerson wrote:
> It looks like this could all be converted to use classes by replacing
'extends'
> with 'implements'. I'm not sure whether it would be a valuable test or not
> though.

Done.

Powered by Google App Engine
This is Rietveld 408576698