Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java

Issue 11314019: Using 'interface' and 'abstract' for methods should produce error (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
diff --git a/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java b/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
index b2deab623e1d5e5636d3ade101cb14cae3bc514c..eae6efdd12806a3e1e62e34e7f912c6ca76f27ca 100644
--- a/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
+++ b/compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java
@@ -15,8 +15,6 @@ import com.google.dart.compiler.SubSystem;
* the beginning default English translation of the message.
*/
public enum ParserErrorCode implements ErrorCode {
- ABSTRACT_MEMBER_IN_INTERFACE("Abstract members are not allowed in interfaces"),
- ABSTRACT_METHOD_WITH_BODY("Abstract method cannot have a body"),
ABSTRACT_TOP_LEVEL_ELEMENT("Only class can be abstract top-level element"),
BREAK_OUTSIDE_OF_LOOP("'break' used outside of loop, case statement"),
BUILT_IN_IDENTIFIER_AS_TYPE_NAME("Built-in identifier cannot be used as type name"),
@@ -33,13 +31,14 @@ public enum ParserErrorCode implements ErrorCode {
DEFAULT_POSITIONAL_PARAMETER("Positional parameters cannot have default values"),
DEPRECATED_CATCH("This style of catch clause has been deprecated. Please use the 'on' <type> " +
"'catch' '(' <identifier> (',' <identifier>)? ')' form."),
+ DEPRECATED_ABSTRACT_METHOD("Modifier 'abstract' is deprecated for methods without body. Remove it."),
DEPRECATED_GETTER("The presence of parentheses after the name of the getter "
+ "has been deprecated and will soon be disallowed. Please remove the parentheses."),
+ DEPRECATED_INTERFACE("Deprecated declaration of the 'interface', use abstract 'class' instead"),
DEPRECATED_USE_OF_FACTORY_KEYWORD("Deprecated use of the 'factory' keyword: use 'default' instead"),
DEPRECATED_RAW_STRING("The use of '@' to prefix a raw string has been deprecated; use 'r' instead"),
DEPRECATED_RESOURCE_DIRECTIVE("The #resource directive has been deprecated and will soon be disallowed"),
DIRECTIVE_OUT_OF_ORDER("Directive out of order"),
- DISALLOWED_ABSTRACT_KEYWORD("Abstract keyword not allowed here"),
// TODO(zundel): error message needs JUnit test (unreachable code?)
DISALLOWED_FACTORY_KEYWORD("Factory keyword not allowed here"),
DISALLOWED_STATIC_KEYWORD("Static keyword not allowed here"),
@@ -75,13 +74,11 @@ public enum ParserErrorCode implements ErrorCode {
EXPECTED_VAR_FINAL_OR_TYPE("Expected 'var', 'final' or type"),
EXTERNAL_ONLY_METHOD("Only a top-level function, a method, a getter, a setter or an non-redirecting constructor can be specified as external"),
EXTERNAL_METHOD_BODY("External methods cannot have body"),
- EXTERNAL_ABSTRACT("External methods cannot be abstract"),
INVALID_SEPARATOR_FOR_NAMED("Use ':' between a named parameter and its value"),
INVALID_SEPARATOR_FOR_OPTIONAL("Use '=' between an optional parameter and its value"),
// TODO(zundel): this error message is out of date
NATIVE_ONLY_CLASS("Native keyword can be specified only for classes"),
NATIVE_ONLY_CORE_LIB("Native keyword can be used only in corelib"),
- FACTORY_CANNOT_BE_ABSTRACT("A factory cannot be abstract"),
FACTORY_CANNOT_BE_STATIC("A factory cannot be static"),
FACTORY_CANNOT_BE_TOP_LEVEL("A factory cannot be top level, it must be a member of a class"),
FACTORY_MEMBER_IN_INTERFACE("Factory members are not allowed in interfaces"),
@@ -123,7 +120,6 @@ public enum ParserErrorCode implements ErrorCode {
REDIRECTING_CONSTRUCTOR_ITSELF("Redirecting constructor cannot have initializers"),
REDIRECTING_CONSTRUCTOR_MULTIPLE("Multiple redirecting constructor invocations"),
REDIRECTING_CONSTRUCTOR_OTHER("Redirecting constructor cannot have initializers"),
- STATIC_MEMBERS_CANNOT_BE_ABSTRACT("Static members cannot be abstract"),
SUPER_CONSTRUCTOR_MULTIPLE("'super' must be called only once in the initialization list"),
SUPER_CANNOT_BE_USED_AS_THE_SECOND_OPERAND(
"'super' cannot be used as the second operand in a binary expression."),

Powered by Google App Engine
This is Rietveld 408576698