Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 11293063: Add missing path_separator arguments after sdk paths became (Closed)

Created:
8 years, 1 month ago by dgrove
Modified:
8 years, 1 month ago
Reviewers:
cshapiro, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add missing path_separator arguments after sdk paths became deeper. TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=14482

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/benchmark_test.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
dgrove
8 years, 1 month ago (2012-11-02 16:01:42 UTC) #1
Ivan Posva
LGTM -ip https://codereview.chromium.org/11293063/diff/1/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://codereview.chromium.org/11293063/diff/1/runtime/vm/benchmark_test.cc#newcode247 runtime/vm/benchmark_test.cc:247: path_separator, Carl, any reason why this was ...
8 years, 1 month ago (2012-11-02 16:05:09 UTC) #2
cshapiro
8 years, 1 month ago (2012-11-02 17:24:34 UTC) #3
https://codereview.chromium.org/11293063/diff/1/runtime/vm/benchmark_test.cc
File runtime/vm/benchmark_test.cc (right):

https://codereview.chromium.org/11293063/diff/1/runtime/vm/benchmark_test.cc#...
runtime/vm/benchmark_test.cc:247: path_separator,
Only format control string literals are checked.

Consider the following example

  1 #include <stdio.h>
  2 int main(int argc, char** argv) {
  3   const char* fmt = "%s";
  4   printf(fmt, 9);
  5   printf("%s", 9);
  6   return 0;
  7 }

Here is what the compiler says after being invoked with -Wformat=2

  test.c: In function ‘int main(int, char**)’:
  test.c:4:3: warning: format not a string literal, argument types not checked
[-Wformat-nonliteral]
  test.c:5:17: warning: format ‘%s’ expects argument of type ‘char*’, but
argument 2 has type ‘int’ [-Wformat]

Powered by Google App Engine
This is Rietveld 408576698