Add missing path_separator arguments after sdk paths became

runtime/vm/benchmark_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/benchmark_test.h"
 
 #include "bin/file.h"
 
 #include "platform/assert.h"
 
@@ skipping 226 matching lines @@
       "%s%ssdk%slib%s_internal%scompiler%scompiler.dart";
   const char* path_separator = File::PathSeparator();
   ASSERT(path_separator != NULL && strlen(path_separator) == 1);
   char* ptr = strrchr(dart2js_path, *path_separator);
   while (ptr != NULL) {
     *ptr = '\0';
     OS::SNPrint(buffer, 2048, compiler_path,
                 dart2js_path,
                 path_separator,
                 path_separator,
+                path_separator,

[Ivan Posva, 2012/11/02 16:05:09]

Carl, any reason why this was not caught during the build? Shouldn't the      
PRINTF_ATTRIBUTE(3, 4) on OS::SNPrint catch issues like these?

[cshapiro, 2012/11/02 17:24:34]

Only format control string literals are checked.

Consider the following example

  1 #include <stdio.h>
  2 int main(int argc, char** argv) {
  3   const char* fmt = "%s";
  4   printf(fmt, 9);
  5   printf("%s", 9);
  6   return 0;
  7 }

Here is what the compiler says after being invoked with -Wformat=2

  test.c: In function ‘int main(int, char**)’:
  test.c:4:3: warning: format not a string literal, argument types not checked
[-Wformat-nonliteral]
  test.c:5:17: warning: format ‘%s’ expects argument of type ‘char*’, but
argument 2 has type ‘int’ [-Wformat]

+                path_separator,
                 path_separator);
     if (File::Exists(buffer)) {
       break;
     }
     ptr = strrchr(dart2js_path, *path_separator);
   }
   if (ptr == NULL) {
     free(dart2js_path);
     dart2js_path = NULL;
   }
@@ skipping 125 matching lines @@
   Dart_Handle cls = Dart_GetClass(lib, NewString("StackFrameTest"));
   Dart_Handle result = Dart_Invoke(cls, NewString("testMain"), 0, NULL);
   EXPECT_VALID(result);
   int64_t elapsed_time = 0;
   result = Dart_IntegerToInt64(result, &elapsed_time);
   EXPECT_VALID(result);
   benchmark->set_score(elapsed_time);
 }
 
 }  // namespace dart