Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123813002: Move symbol table from per isolate snapshot to vm isolate snapshot, this reduces the per isolate in… (Closed)

Created:
5 years, 7 months ago by siva
Modified:
5 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Move symbol table from per isolate snapshot to vm isolate snapshot, this reduces the per isolate initial heap size from New space (0k of 1024k) Old space (1274k of 1536k) to New space (0k of 1024k) Old space (756k of 1280k) R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=45795

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+853 lines, -277 lines) Patch
M runtime/bin/run_vm_tests.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/snapshot_in.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 3 4 5 6 7 3 chunks +12 lines, -6 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 5 6 7 4 chunks +41 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_message.h View 1 2 3 4 5 6 7 5 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/dart_api_message.cc View 1 2 3 4 5 6 7 11 chunks +38 lines, -14 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 5 chunks +14 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 5 6 7 15 chunks +142 lines, -57 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 6 7 30 chunks +321 lines, -50 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 4 5 6 7 31 chunks +86 lines, -51 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 3 4 5 6 7 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/symbols.cc View 1 2 3 4 5 6 7 3 chunks +138 lines, -64 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 7 months ago (2015-05-07 20:04:49 UTC) #2
hausner
LGTM
5 years, 7 months ago (2015-05-08 00:02:13 UTC) #3
siva
synched to tot.
5 years, 7 months ago (2015-05-14 20:03:35 UTC) #4
siva
5 years, 7 months ago (2015-05-14 20:15:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as r45795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698