runtime/vm/dart_api_impl_test.cc - Issue 1123813002: Move symbol table from per isolate snapshot to vm isolate snapshot, this reduces the per isolate in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 1123813002: Move symbol table from per isolate snapshot to vm isolate snapshot, this reduces the per isolate in… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl_test.cc

===================================================================

--- runtime/vm/dart_api_impl_test.cc (revision 45789)

+++ runtime/vm/dart_api_impl_test.cc (working copy)

@@ -8541,7 +8541,7 @@

EXPECT_EQ(reinterpret_cast<void*>(&canonical_str_peer), peer);

// Test with a one byte ascii string.

- const char* ascii = "string";

+ const char* ascii = "?unseen";

expected_length = strlen(ascii);

Dart_Handle ascii_str = NewString(ascii);

EXPECT_VALID(ascii_str);

@@ -8607,7 +8607,7 @@

}

// Test with a symbol (hash value should be preserved on externalization).

- const char* symbol_ascii = "string";

+ const char* symbol_ascii = "?unseen";

expected_length = strlen(symbol_ascii);

Dart_Handle symbol_str =

Api::NewHandle(isolate, Symbols::New(symbol_ascii, expected_length));

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/dart_api_message.h » ('j') | no next file with comments »