Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: runtime/vm/symbols.h

Issue 1123813002: Move symbol table from per isolate snapshot to vm isolate snapshot, this reduces the per isolate in… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/symbols.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.h
===================================================================
--- runtime/vm/symbols.h (revision 45789)
+++ runtime/vm/symbols.h (working copy)
@@ -537,7 +537,14 @@
// Initialize frequently used symbols in the vm isolate.
static void InitOnce(Isolate* isolate);
+ static void InitOnceFromSnapshot(Isolate* isolate);
+ // Add all the symbols that were cached in the VM isolate to this isolate,
+ // we do this when an Isolate is not created from the snapshot so that
+ // we get a unified symbol table that can be be dumped into the VM isolate
+ // snapshot.
+ static void AddPredefinedSymbolsToIsolate();
+
// Initialize and setup a symbol table for the isolate.
static void SetupSymbolTable(Isolate* isolate);
@@ -592,9 +599,6 @@
template<typename StringType>
static RawString* NewSymbol(const StringType& str);
- // Add the string into the VM isolate symbol table.
- static void AddToVMIsolate(const String& str);
-
static intptr_t LookupVMSymbol(RawObject* obj);
static RawObject* GetVMSymbol(intptr_t object_id);
static bool IsVMSymbolId(intptr_t object_id) {
@@ -610,6 +614,7 @@
// List of handles for predefined symbols.
static String* symbol_handles_[kMaxPredefinedId];
+ friend class Dart;
friend class String;
friend class SnapshotReader;
friend class SnapshotWriter;
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/symbols.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698