Issue 11198072: Inline load and store index on Float32Arrays.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -7 lines)			Patch
M	runtime/platform/globals.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4	4 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	4 chunks	+25 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	4 chunks	+25 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://codereview.chromium.org/11198072/diff/2001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/11198072/diff/2001/runtime/vm/flow_graph_optimizer.cc#newcode458 runtime/vm/flow_graph_optimizer.cc:458: } else if (class_id == kFloat64ArrayCid) { Aren't the ...

8 years, 2 months ago (2012-10-19 00:41:53 UTC) #1

srdjan

8 years, 2 months ago (2012-10-19 00:58:33 UTC) #2

LGTM with comments

https://codereview.chromium.org/11198072/diff/7001/runtime/vm/flow_graph_opti...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11198072/diff/7001/runtime/vm/flow_graph_opti...
runtime/vm/flow_graph_optimizer.cc:449: if (class_id == kFloat32ArrayCid ||
class_id == kFloat64ArrayCid) {
Use parenthesis around == expressions.

https://codereview.chromium.org/11198072/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/11198072/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:972: } else if (class_id() ==
kFloat64ArrayCid) {
else {
  ASSERT(class_id() == kFloat64ArrayCid)
  ...
}

https://codereview.chromium.org/11198072/diff/7001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/11198072/diff/7001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_x64.cc:930: __ movsd(locs()->out().xmm_reg(),
element_address);
} else {
  ASSERT( ..)
...
}

Expand Messages | Collapse Messages

Issue 11198072: Inline load and store index on Float32Arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Test suites pass #

Patch Set 3 : Codereview fixes. #

Patch Set 4 : Final code review changes. #

Patch Set 5 : Final patch #

Messages