Inline load and store index on Float32Arrays.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 409 matching lines @@
 bool FlowGraphOptimizer::TryReplaceWithStoreIndexed(InstanceCallInstr* call) {
   // TODO(fschneider): Optimize []= operator in checked mode as well.
   if (FLAG_enable_type_checks) return false;
   const intptr_t class_id = ReceiverClassId(call);
   ICData& value_check = ICData::Handle();
   switch (class_id) {
     case kArrayCid:
     case kGrowableObjectArrayCid:
       // Acceptable store index classes.
       break;
+    case kFloat32ArrayCid:
     case kFloat64ArrayCid: {
       // Check that value is always double.
       value_check = call->ic_data()->AsUnaryClassChecksForArgNr(2);
       if ((value_check.NumberOfChecks() != 1) ||
           (value_check.GetReceiverClassIdAt(0) != kDoubleCid)) {
         return false;
       }
       break;
     }
     default:
       return false;
   }
   Value* array = NULL;
   Value* index = NULL;
   intptr_t array_cid = PrepareIndexedOp(call, class_id, &array, &index);
   Value* value = call->ArgumentAt(2)->value();
   // Check if store barrier is needed.
   bool needs_store_barrier = true;
-  if (class_id == kFloat64ArrayCid) {
+  if (class_id == kFloat32ArrayCid) {
     ASSERT(!value_check.IsNull());
     InsertBefore(call,
                  new CheckClassInstr(value->Copy(),
+                                     call->deopt_id(),
+                                     value_check),
+                 call->env(),
+                 Definition::kEffect);
+    needs_store_barrier = false;
+  } else if (class_id == kFloat64ArrayCid) {

[srdjan, 2012/10/19 00:41:53]

Aren't the kFloat64ArrayCid and kFloat32ArrayCid the same code?

+    ASSERT(!value_check.IsNull());
+    InsertBefore(call,
+                 new CheckClassInstr(value->Copy(),
                                      call->deopt_id(),
                                      value_check),
                  call->env(),
                  Definition::kEffect);
     needs_store_barrier = false;
   } else if (ArgIsAlwaysSmi(*call->ic_data(), 2)) {
     InsertBefore(call,
                  new CheckSmiInstr(value->Copy(), call->deopt_id()),
                  call->env(),
                  Definition::kEffect);
     needs_store_barrier = false;
   }
 
   Definition* array_op =
       new StoreIndexedInstr(array, index, value,
                             needs_store_barrier, array_cid, call->deopt_id());
   call->ReplaceWith(array_op, current_iterator());
   RemovePushArguments(call);
   return true;
 }
 
 
 
 bool FlowGraphOptimizer::TryReplaceWithLoadIndexed(InstanceCallInstr* call) {
   const intptr_t class_id = ReceiverClassId(call);
   switch (class_id) {
     case kArrayCid:
     case kImmutableArrayCid:
     case kGrowableObjectArrayCid:
+    case kFloat32ArrayCid:
     case kFloat64ArrayCid:
       // Acceptable load index classes.
       break;
     default:
       return false;
   }
   Value* array = NULL;
   Value* index = NULL;
   intptr_t array_cid = PrepareIndexedOp(call, class_id, &array, &index);
   Definition* array_op = new LoadIndexedInstr(array, index, array_cid);
@@ skipping 2844 matching lines @@
 
   if (FLAG_trace_constant_propagation) {
     OS::Print("\n==== After constant propagation ====\n");
     FlowGraphPrinter printer(*graph_);
     printer.PrintBlocks();
   }
 }
 
 
 }  // namespace dart