Inline load and store index on Float32Arrays.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 946 matching lines @@
 void LoadIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register array = locs()->in(0).reg();
   Location index = locs()->in(1);
   FieldAddress element_address = index.IsRegister() ?
       FlowGraphCompiler::ElementAddressForRegIndex(
           class_id(), array, index.reg()) :
       FlowGraphCompiler::ElementAddressForIntIndex(
           class_id(), array, Smi::Cast(index.constant()).Value());
 
   if (representation() == kUnboxedDouble) {
-    __ movsd(locs()->out().xmm_reg(), element_address);
+    if (class_id() == kFloat32ArrayCid) {
+      // Load single precision float.
+      __ movss(locs()->out().xmm_reg(), element_address);
+      // Promote to double.
+      __ cvtss2sd(locs()->out().xmm_reg(), locs()->out().xmm_reg());
+    } else if (class_id() == kFloat64ArrayCid) {
+      __ movsd(locs()->out().xmm_reg(), element_address);
+    }
   } else {
     __ movl(locs()->out().reg(), element_address);
   }
 }
 
 
 LocationSummary* StoreIndexedInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 3;
-  const intptr_t kNumTemps = 0;
+  intptr_t kNumTemps = 0;
+  if (class_id() == kFloat32ArrayCid) {
+    kNumTemps = 1;
+  }

[srdjan, 2012/10/19 00:41:53]

I would prefer const intptr_t kNumTemps = class_id() == kFloat32ArrayCid ? 1 :
0;

   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+  if (class_id() == kFloat32ArrayCid) {
+    locs->set_temp(0, Location::RequiresXmmRegister());
+  }
   locs->set_in(0, Location::RequiresRegister());
   locs->set_in(1, CanBeImmediateIndex(index())
                     ? Location::RegisterOrConstant(index())
                     : Location::RequiresRegister());
   if (RequiredInputRepresentation(2) == kUnboxedDouble) {
     // TODO(srdjan): Support Float64 constants.
     locs->set_in(2, Location::RequiresXmmRegister());
   } else {
     locs->set_in(2, ShouldEmitStoreBarrier()
                       ? Location::WritableRegister()
                       : Location::RegisterOrConstant(value()));
   }
   return locs;
 }
 
 
 void StoreIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register array = locs()->in(0).reg();
   Location index = locs()->in(1);
 
   FieldAddress element_address = index.IsRegister() ?
       FlowGraphCompiler::ElementAddressForRegIndex(
           class_id(), array, index.reg()) :
       FlowGraphCompiler::ElementAddressForIntIndex(
           class_id(), array, Smi::Cast(index.constant()).Value());
 
+  if (class_id() == kFloat32ArrayCid) {
+    // Convert to single precision.
+    __ cvtsd2ss(locs()->temp(0).xmm_reg(), locs()->in(2).xmm_reg());
+    // Store.
+    __ movss(element_address, locs()->temp(0).xmm_reg());
+    return;
+  }
+
   if (class_id() == kFloat64ArrayCid) {
     __ movsd(element_address, locs()->in(2).xmm_reg());
     return;
   }
 
   if (ShouldEmitStoreBarrier()) {
     Register value = locs()->in(2).reg();
     __ StoreIntoObject(array, element_address, value);
     return;
   }
@@ skipping 1191 matching lines @@
 
 void CheckArrayBoundInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   const DeoptReasonId deopt_reason =
       (array_type() == kGrowableObjectArrayCid) ?
           kDeoptLoadIndexedGrowableArray : kDeoptLoadIndexedFixedArray;
   Label* deopt = compiler->AddDeoptStub(deopt_id(),
                                         deopt_reason);
   ASSERT((array_type() == kArrayCid) ||
          (array_type() == kImmutableArrayCid) ||
          (array_type() == kGrowableObjectArrayCid) ||
-         (array_type() == kFloat64ArrayCid));
+         (array_type() == kFloat64ArrayCid) ||
+         (array_type() == kFloat32ArrayCid));
   intptr_t length_offset = -1;
   if (array_type() == kGrowableObjectArrayCid) {
     length_offset = GrowableObjectArray::length_offset();
   } else if (array_type() == kFloat64ArrayCid) {
     length_offset = Float64Array::length_offset();
+  } else if (array_type() == kFloat32ArrayCid) {
+    length_offset = Float32Array::length_offset();
   } else {
     length_offset = Array::length_offset();
   }
   // This case should not have created a bound check instruction.
   ASSERT(!(locs()->in(0).IsConstant() && locs()->in(1).IsConstant()));
 
   if (locs()->in(1).IsConstant()) {
     Register receiver = locs()->in(0).reg();
     const Object& constant = locs()->in(1).constant();
     ASSERT(constant.IsSmi());
@@ skipping 314 matching lines @@
   __ pcmpeqq(XMM0, XMM0);  // Generate all 1's.
   __ pxor(value, XMM0);
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64