Issue 11184015: Rename ie to ie9.

Issue 11184015: Rename ie to ie9. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
Bill Hesse, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Rename ie to ie9. Committed: https://code.google.com/p/dart/source/detail?r=13748

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -45 lines)			Patch
M	samples/tests/samples/samples.status	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/benchmark_smoke/benchmark_smoke.status	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/dart2js.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/html.status	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/json/json.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 2	4 chunks	+4 lines, -6 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 2 3	5 chunks	+17 lines, -14 lines	0 comments	Download
M	utils/compiler/buildbot.py	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Part one of a many part process to distinguish between browser versions in tests. Also ...

8 years, 2 months ago (2012-10-17 00:28:50 UTC) #1

Bill Hesse

LGTM. http://codereview.chromium.org/11184015/diff/15/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/11184015/diff/15/tools/testing/dart/test_suite.dart#newcode1415 tools/testing/dart/test_suite.dart:1415: 'ff']); Nit: Line break not at least-precedence operator. ...

8 years, 2 months ago (2012-10-17 14:18:50 UTC) #2

Emily Fortuna

8 years, 2 months ago (2012-10-17 17:42:44 UTC) #3

http://codereview.chromium.org/11184015/diff/15/utils/compiler/buildbot.py
File utils/compiler/buildbot.py (right):

http://codereview.chromium.org/11184015/diff/15/utils/compiler/buildbot.py#ne...
utils/compiler/buildbot.py:171: runtime = 'ie9'
On 2012/10/17 14:18:50, Bill Hesse wrote:
> If there is a plan to push this change through the buildbots, file a bug. 
Else
> OK.

I filed a bug and added a comment about it:
http://code.google.com/p/dart/issues/detail?id=6003

Expand Messages | Collapse Messages