Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11184015: Rename ie to ie9. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 13713)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -77,6 +77,7 @@
String displayName;
TestOutput output;
bool isNegative;
+ bool usesWebDriver;
Set<String> expectedOutcomes;
TestCaseEvent completedHandler;
TestInformation info;
@@ -87,7 +88,8 @@
this.completedHandler,
this.expectedOutcomes,
{this.isNegative: false,
- this.info: null}) {
+ this.info: null,
+ this.usesWebDriver: false}) {
if (!isNegative) {
this.isNegative = displayName.contains("negative_test");
}
@@ -165,10 +167,6 @@
List<String> get batchTestArguments => commands.last().arguments;
void completed() { completedHandler(this); }
-
- bool get usesWebDriver => Contains(
- configuration['runtime'],
- const ['chrome', 'dartium', 'ff', 'safari', 'ie', 'opera']);
}
@@ -621,7 +619,7 @@
stdout.add('test.dart: Compilation finished $suffix\n');
if (currentStep == totalSteps - 1 && testCase.usesWebDriver &&
!testCase.configuration['noBatch']) {
- // Note: processQueue will always be non-null for runtime == ie, ff,
+ // Note: processQueue will always be non-null for runtime == ie9, ff,
// safari, chrome, opera. (It is only null for runtime == vm)
// This RunningProcess object is done, and hands over control to
// BatchRunner.startTest(), which handles reporting, etc.
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698