Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: tools/testing/dart/test_options.dart

Issue 11184015: Rename ie to ie9. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language_dart2js.status ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
===================================================================
--- tools/testing/dart/test_options.dart (revision 13713)
+++ tools/testing/dart/test_options.dart (working copy)
@@ -74,7 +74,7 @@
dart2js: Compile dart code to JavaScript by running dart2js.
(only valid with the following runtimes: d8, drt, chrome,
- safari, ie, firefox, opera, none (compile only)),
+ safari, ie9, firefox, opera, none (compile only)),
dartc: Perform static analysis on Dart code by running dartc.
(only valid with the following runtimes: none)''',
@@ -95,14 +95,14 @@
dartium: Run Dart or JavaScript in Dartium.
- [ff | chrome | safari | ie | opera]: Run JavaScript in the specified
+ [ff | chrome | safari | ie9 | opera]: Run JavaScript in the specified
browser.
none: No runtime, compile only (for example, used for dartc static analysis
tests).''',
['-r', '--runtime'],
['vm', 'd8', 'jsshell', 'drt', 'dartium', 'ff', 'firefox',
- 'chrome', 'safari', 'ie', 'opera', 'none'],
+ 'chrome', 'safari', 'ie9', 'opera', 'none'],
'vm'),
new _TestOptionSpecification(
'arch',
@@ -398,7 +398,7 @@
// dart2js_drt will be duplicating work. If later we don't need 'none'
// with dart2js, we should remove it from here.
validRuntimes = const ['d8', 'jsshell', 'drt', 'none', 'dartium',
- 'ff', 'chrome', 'safari', 'ie', 'opera'];
+ 'ff', 'chrome', 'safari', 'ie9', 'opera'];
break;
case 'dartc':
validRuntimes = const ['none'];
@@ -413,7 +413,7 @@
print("Warning: combination of ${config['compiler']} and "
"${config['runtime']} is invalid. Skipping this combination.");
}
- if (config['runtime'] == 'ie' &&
+ if (config['runtime'] == 'ie9' &&
Platform.operatingSystem != 'windows') {
isValid = false;
print("Warning cannot run Internet Explorer on non-Windows operating"
@@ -560,7 +560,7 @@
timeout *= 2;
}
if (Contains(configuration['runtime'],
- const ['ie', 'ff', 'chrome', 'safari', 'opera'])) {
+ const ['ie9', 'ff', 'chrome', 'safari', 'opera'])) {
timeout *= 8; // Allow additional time for browser testing to run.
}
break;
« no previous file with comments | « tests/language/language_dart2js.status ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698