Issue 11148014: Land 'Fix a crash related to obsolete factory syntax.'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11148014: Land 'Fix a crash related to obsolete factory syntax.'. (Closed)

Created:
8 years, 2 months ago by karlklose

Modified:
8 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Land 'Fix a crash related to obsolete factory syntax.'. Original CL and review at https://codereview.chromium.org/11117022/. This CL addresses comments on the original CL. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=13650

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -6 lines)			Patch
M	lib/compiler/implementation/scanner/class_element_parser.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM. Thanks, Karl!