Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: lib/compiler/implementation/scanner/listener.dart

Issue 11148014: Land 'Fix a crash related to obsolete factory syntax.'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/scanner/listener.dart
diff --git a/lib/compiler/implementation/scanner/listener.dart b/lib/compiler/implementation/scanner/listener.dart
index 424d17f85b17f9c4ae2cb5fa442f061d4c526f74..a989ef4ab4bae9a1384ab4160bdca955d8ecb4ba 100644
--- a/lib/compiler/implementation/scanner/listener.dart
+++ b/lib/compiler/implementation/scanner/listener.dart
@@ -1663,11 +1663,17 @@ class NodeListener extends ElementListener {
Token endToken) {
Statement body = popNode();
NodeList formals = popNode();
- NodeList typeParameters = popNode(); // TODO(karlklose): don't throw away.
- Node name = popNode();
+ // TODO(karlklose): don't throw type parameters away.
+ NodeList typeParameters;
+ Node name;
if (periodBeforeName !== null) {
+ name = popNode();
+ typeParameters = popNode();
// A library prefix was handled in [handleQualified].
name = new Send(popNode(), name);
+ } else {
+ typeParameters = popNode();
+ name = popNode();
}
// TODO(ahe): Move this parsing to the parser.
int modifierCount = 0;
« no previous file with comments | « lib/compiler/implementation/scanner/class_element_parser.dart ('k') | lib/compiler/implementation/tree/unparser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698