Issue 11099044: Register parameter types for closure invocations to the backend.

Issue 11099044: Register parameter types for closure invocations to the backend. (Closed)

Created:
8 years, 2 months ago by floitsch

Modified:
8 years, 2 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Register parameter types for closure invocations to the backend. Submit CL 11091029 on behalf of Nicolas. https://codereview.chromium.org/11091029 BUG=http://dartbug.com/5744 Committed: https://code.google.com/p/dart/source/detail?r=13492

Patch Set 2 : Disable call_test for VM. #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
M	lib/compiler/implementation/js_backend/backend.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1	1 chunk	+1 line, -0 lines	2 comments	Download
M	tests/isolate/isolate.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A +	tests/language/call_test.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Only minor changes wrt the original CL. The biggest change is the requirement to ensure ...

8 years, 2 months ago (2012-10-10 20:09:33 UTC) #1

ngeoffray

http://codereview.chromium.org/11099044/diff/2001/tests/compiler/dart2js/mock_compiler.dart File tests/compiler/dart2js/mock_compiler.dart (right): http://codereview.chromium.org/11099044/diff/2001/tests/compiler/dart2js/mock_compiler.dart#newcode93 tests/compiler/dart2js/mock_compiler.dart:93: objectClass.ensureResolved(this); Did you find out why you need to ...

8 years, 2 months ago (2012-10-15 12:53:39 UTC) #3

floitsch

8 years, 2 months ago (2012-10-18 15:59:52 UTC) #4

http://codereview.chromium.org/11099044/diff/2001/tests/compiler/dart2js/mock...
File tests/compiler/dart2js/mock_compiler.dart (right):

http://codereview.chromium.org/11099044/diff/2001/tests/compiler/dart2js/mock...
tests/compiler/dart2js/mock_compiler.dart:93: objectClass.ensureResolved(this);
On 2012/10/15 12:53:39, ngeoffray wrote:
> Did you find out why you need to do this? Maybe add a comment.
https://codereview.chromium.org/11184042/

Expand Messages | Collapse Messages