Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 11184042: Add comment to mock-compiler. (Closed)

Created:
8 years, 2 months ago by floitsch
Modified:
8 years, 2 months ago
Reviewers:
karlklose, ahe, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add comment to mock-compiler. Sample backtrace: #0 Object.noSuchMethod (dart:core-patch:600:3) #1 PartialTypeTree.newNode (file:///dart/lib/compiler/implementation/universe/partial_type_tree.dart:47:52) #2 PartialTypeTree.findNode (file:///dart/lib/compiler/implementation/universe/partial_type_tree.dart:76:21) #3 SelectorMap.[]= (file:///dart/lib/compiler/implementation/universe/selector_map.dart:25:39) #4 ArgumentTypesRegistry.registerDynamicInvocation (file:///dart/lib/compiler/implementation/js_backend/backend.dart:520:22) #5 JavaScriptBackend.registerDynamicInvocation (file:////dart/lib/compiler/implementation/js_backend/backend.dart:774:44) #6 SsaCodeGenerator.visitInvokeClosure (file:///dart/lib/compiler/implementation/ssa/codegen.dart:1556:38) #7 HInvokeClosure.accept (file:///dart/lib/compiler/implementation/ssa/nodes.dart:1323:57) Committed: https://code.google.com/p/dart/source/detail?r=13892

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +4 lines, -0 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
8 years, 2 months ago (2012-10-18 15:59:33 UTC) #1
ahe
Thanks for the explanation! LGTM https://codereview.chromium.org/11184042/diff/1/tests/compiler/dart2js/mock_compiler.dart File tests/compiler/dart2js/mock_compiler.dart (right): https://codereview.chromium.org/11184042/diff/1/tests/compiler/dart2js/mock_compiler.dart#newcode100 tests/compiler/dart2js/mock_compiler.dart:100: // dynamic invocation the ...
8 years, 2 months ago (2012-10-18 16:42:30 UTC) #2
floitsch
https://codereview.chromium.org/11184042/diff/1/tests/compiler/dart2js/mock_compiler.dart File tests/compiler/dart2js/mock_compiler.dart (right): https://codereview.chromium.org/11184042/diff/1/tests/compiler/dart2js/mock_compiler.dart#newcode100 tests/compiler/dart2js/mock_compiler.dart:100: // dynamic invocation the ArgumentTypesRegistry eventually iterates over On ...
8 years, 2 months ago (2012-10-18 17:16:49 UTC) #3
ahe
8 years, 2 months ago (2012-10-22 16:50:08 UTC) #4
https://codereview.chromium.org/11184042/diff/1/tests/compiler/dart2js/mock_c...
File tests/compiler/dart2js/mock_compiler.dart (right):

https://codereview.chromium.org/11184042/diff/1/tests/compiler/dart2js/mock_c...
tests/compiler/dart2js/mock_compiler.dart:100: // dynamic invocation the
ArgumentTypesRegistry eventually iterates over
On 2012/10/18 17:16:50, floitsch wrote:
> On 2012/10/18 16:42:30, ahe wrote:
> > In that case, the ArgumentTypesRegistry registry should really make sure
that
> > objectClass is resolved.
> Should I file a bug?

Yes, that would be great!

Powered by Google App Engine
This is Rietveld 408576698