Issue 11091029: Fix for issue 5744: also register parameter types for closure invocations to the backend.

Issue 11091029: Fix for issue 5744: also register parameter types for closure invocations to the backend. (Closed)

Created:
8 years, 2 months ago by ngeoffray

Modified:
8 years, 2 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 5744: also register parameter types for closure invocations to the backend. Submitted in CL 11099044: http://codereview.chromium.org/11099044/

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+5 lines, -0 lines	2 comments	Download
	A	tests/language/call_test.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

http://codereview.chromium.org/11091029/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): http://codereview.chromium.org/11091029/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode1556 lib/compiler/implementation/ssa/codegen.dart:1556: backend.registerDynamicInvocation(node, call, types); FYI: this doesn't pass in checked ...

8 years, 2 months ago (2012-10-10 08:56:32 UTC) #3

ngeoffray

8 years, 2 months ago (2012-10-10 09:35:30 UTC) #5

Thanks Florian and Peter

http://codereview.chromium.org/11091029/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/11091029/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/codegen.dart:1556:
backend.registerDynamicInvocation(node, call, types);
On 2012/10/10 08:56:33, floitsch wrote:
> FYI: this doesn't pass in checked mode: registerDynamicInvocation expects an
> HInvokeDynamicMethod and not an HInvokeClosure.

Good catch. I probably won't have time to run all tests and submit today, but
only tomorrow. So please feel free to fix it and submit it if it's super urgent.

Expand Messages | Collapse Messages